-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iconize 2.11.9 conflicts with windows icons and Metabind #438
Comments
I'm having a similar issue. For example, my note has a hand emoji like: 👆, which was added using the Mac Emoji picker, which is behaving like this. I'm using Font Awesome Solid and Lucide Icons and for Emoji Style my choice is "Native" |
is it only for emojis? if so, could you check if changing the emoji mode in the settings to "native" fixes this. |
That helps a bit however it still destroys dataview tables when windows icons appear inside the dataview table. |
Makes me think about was I was seeing with Iconize 2.11.7, yesterday -> #412 (comment) (only tested with emojis/twemojis though) which I think I still get with Iconize 2.11.9 (but I didn't got the opportunity to properly test this yet) Edit: Selected the wrong reply to quote 🙈 Edit-2: Setting the emojis style to any of the options available, then Edit-3: I'm also having this issue 👇 ...
|
Same error here: bullet points are being lost |
would it be possible for someone to give me a minimal reproduction example. especially if it is affecting dataview + iconize the specific dataview query. |
I'm also experiencing this but with the Tasks plugin. Tasks uses emojis to indicate different due dates, priorities, etc. The emojis are only visible when the cursor is placed in the line containing the emoji, but when you select a different line, the emoji disappears. Additionally, when that task is queried using Dataview, the emoji is replaced by the text "null". |
I'm experiencing this with inline emojis on macOS, I can see them in source mode but as soon as I change to read mode emoji is replaced with "null". |
I've the same massive problems on all levels since the latest update. |
just fyi: i have a working solution, just need to adjust the code a bit and adapt it to icons as well. i'll keep you updated here. |
hey there, I've pushed a commit to fix the latest issues. at least I am not able to reproduce any issue related to that anymore. could someone please check out the latest code and see if it works for them? |
Sorry for my potential ignorant comment but don't you need to release a new version for us to test ? 🙈 |
no worries. yes but i want to make sure that everything works before releasing it. you can check the development guide in the readme to get some insights on how to test things locally. if it sounds too complicated i can also upload to built files to GitHub and you can download them. |
You could setup beta releases with BRAT for this. That would allow users to download beta versions via BRAT, without pushing out beta releases to all users. I do that for almost all of my plugins. |
I've got this issue too... Thanks for taking a look at it... Is there a release date for it yet? |
probably this weekend. |
That's awesome news, thanks! As an end user of Obsidian (my days of being a competent coder are long gone) are there any user tests I can do that would be helpful for you? |
yeah so I should setup BRAT in the future, thank you for the suggestion!
sure! because BRAT (or something similar) is not embedded yet, you can copy and paste the These are the steps you need to follow:
Then, hopefully, things will work. |
Thanks @FlorianWoelki ... Do you have a "Buy me a coffee" link? |
that's really lovely! I do, but obviously it's not required. always appreciate the support! |
Thank you for sharing the file 😄 ! I just ran some tests (in the same vault I used before) and it's way better from my side of the screen 😊 : I was able to:
Emojis still seems to render when "they want to" in Live Preview 😊 (#438 (comment)) Edit: Regarding the emojis 😊 : Setting them to |
really awesome to hear that. I am going to check out the native emoji issue. could you maybe give me some text example where it sometimes fails? |
@FlorianWoelki 😊 : Regarding the emojis, this is a very minimal sample I used to test the rendering 😊 There's really nothing fancy 😄 (there's a mix of emojis and Lucide icons ) : :herb:
:sparkles: :LiRedo:
:LiSparkles:
> [!note]
>
> :LiSparkles: Something
- :purple_heart:
- :LiSparkles:
:herb: I did stumbled upon on something I think could be interesting: The emojis which can be rendered in And here's a screenshot, in the 3 views, of the result I get with the small sample I shared above 😊 : For In the screen-recording below, instead of the emojis being rendered when I place my cursor on the line (in the note at the center), the cursor gets "longer" and there seems to be a really tiny space in place of the emoji... Iconize.-.Emojis.-.Lines.movBut if the note is in Iconize.-.Emojis.-.Line.-.Alone.movI do get various mixed results depending on the number of split views open and the mode the notes are in (Source, LP, Reading) But at least, I can now have split views 🥳 !!! |
Seems like there's two issues in one in this thread. Is the code in #438 (comment) meant to fix this?
Because I'm still having that issue when trying to load any notes with inlines. Oddly, one that opens on startup works perfectly, with icons, until I click off of it. |
could you give me something that I can reproduce? |
In case a simple reproduction of this issue with the Tasks plugin is useful, please see obsidian-tasks-group/obsidian-tasks#2766 (comment) |
thanks. it's already fixed and I'll make a release tomorrow. |
i've released the version with the fix. hopefully it is fixed now. |
Describe the bug
Iconize conflicts with windows 11 icons and cause lines where they exist to fail. It also disrupt some Metabind fields.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
What I expected:
https://i.imgur.com/wwLGZTF.png
https://i.imgur.com/oaD8AGD.png
Screenshots
What I got:
https://i.imgur.com/ry8o1tC.png
https://i.imgur.com/goSQEgg.png
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: