Conversation
Co-authored-by: Bao-Qian <bao.github@outlook.com>
… of updating lazy class async
jjw24
added
bug
|
just going to put through a commit to fix this issue i encountered while testing:
|
Thank you for the fix! |
|
great fix, thank you 👍 |
jjw24
removed
the
review in progress
| .Take(Data.Count - MaxCached) | ||
| .Select(x => x.Key)) | ||
| { | ||
| if (!(key.Equals(Constant.ErrorIcon) || key.Equals(Constant.DefaultIcon))) |
There was a problem hiding this comment.
Question: Should we keep this two here in resizing check? I think the ErrorIcon should be replaced with MissingIcon, though.
There was a problem hiding this comment.
Agree, I think we should replace error with missing. Ideally missing img usage should be low, but I still see it often when using Explorer plugin, so since missing and default imgs are commonly used, we should continue to exclude them from removal. I will make a separate pr just to keep it clean.
There was a problem hiding this comment.
I think since they are commonly used, their usage won't be low so that they won't be removed. If they are low, then just removing them won't cause some issue.
Btw, I think we should use Except in Linq to except the key that we don't want to remove, which seems more clear.
3 participants
This PR cherry pick some of the commit in #195 related to the flickering fix.
Closing #42