Skip to content

Conversation

@VictoriousRaptor
Copy link
Contributor

Hide main window when dragging results, so users can see where they're dragging to.

@VictoriousRaptor VictoriousRaptor requested review from Garulf, jjw24, onesounds and taooceros and removed request for taooceros March 25, 2024 15:38
@VictoriousRaptor VictoriousRaptor self-assigned this Mar 25, 2024
@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Mar 25, 2024
@VictoriousRaptor VictoriousRaptor added this to the 1.18.0 milestone Mar 25, 2024
@VictoriousRaptor VictoriousRaptor force-pushed the hide-main-window-when-dragging branch from f2b7b96 to b759de4 Compare March 25, 2024 15:40
@github-actions

This comment has been minimized.

@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

lastpos

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the hide-main-window-when-dragging branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8422820996/attempts/1'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

ℹ️ Warnings Count
ℹ️ non-alpha-in-dictionary 10

See ℹ️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

isDragging = false;

App.API.HideMainWindow();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main window will show later when finishing dragging since we're calling ChangeQuery() in line 156.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main window will only show later when it's a Move action now. Should we amend this? @onesounds @jjw24

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what do you mean? Does change query call make the search window visible again? When I was testing this with moving a file the search window wasn't showing after the drop was done and had to retrigger window to appear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing this PR something did bring back the search window, and I thought it was ChangeQuery. But now I am confused about the logic. Will test later this week.

@jjw24 jjw24 merged commit aadcc39 into dev Mar 27, 2024
@jjw24 jjw24 deleted the hide-main-window-when-dragging branch March 27, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants