-
-
Notifications
You must be signed in to change notification settings - Fork 483
Hide main window when dragging results #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f2b7b96 to
b759de4
Compare
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)lastpos To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8422820996/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ℹ️ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
| isDragging = false; | ||
|
|
||
| App.API.HideMainWindow(); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main window will show later when finishing dragging since we're calling ChangeQuery() in line 156.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main window will only show later when it's a Move action now. Should we amend this? @onesounds @jjw24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry what do you mean? Does change query call make the search window visible again? When I was testing this with moving a file the search window wasn't showing after the drop was done and had to retrigger window to appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I was testing this PR something did bring back the search window, and I thought it was ChangeQuery. But now I am confused about the logic. Will test later this week.
Hide main window when dragging results, so users can see where they're dragging to.