Skip to content

Hide main window when dragging results #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjw24 merged 1 commit into from
Mar 27, 2024
Merged

Hide main window when dragging results #2618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Flow.Launcher/ResultListBox.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.IO;
using System.Windows;
using System.Windows.Controls;
Expand Down Expand Up @@ -137,6 +137,8 @@ private void ResultList_MouseMove(object sender, MouseEventArgs e)

isDragging = false;

App.API.HideMainWindow();

Copy link
Contributor Author

@VictoriousRaptor VictoriousRaptor Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main window will show later when finishing dragging since we're calling ChangeQuery() in line 156.

Copy link
Contributor Author

@VictoriousRaptor VictoriousRaptor Mar 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main window will only show later when it's a Move action now. Should we amend this? @onesounds @jjw24

Copy link
Member

@jjw24 jjw24 Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what do you mean? Does change query call make the search window visible again? When I was testing this with moving a file the search window wasn't showing after the drop was done and had to retrigger window to appear.

Copy link
Contributor Author

@VictoriousRaptor VictoriousRaptor Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was testing this PR something did bring back the search window, and I thought it was ChangeQuery. But now I am confused about the logic. Will test later this week.

var data = new DataObject(DataFormats.FileDrop, new[]
{
path
Expand Down