Merged
Conversation
Member
Author
|
The design of assigning a weight to each plugin is a bit...primitive……. If anyone would have a better design, please feel free to comment. @Flow-Launcher/team |
jjw24
reviewed
Jan 6, 2021
jjw24
added
enhancement
jjw24
requested changes
Jan 6, 2021
Member
jjw24
left a comment
jjw24
left a comment
There was a problem hiding this comment.
got some minor changes from testing
jjw24
previously approved these changes
Jan 11, 2021
jjw24
approved these changes
Jan 11, 2021
Member
Author
|
Should we make the scoring bump higher (50 to 150? ) since sometimes plugins' scores can be low as discussion in #274? |
jjw24
removed
the
review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #274
This currently only bumps the result score based on their Priority.
After #195 , a better way that won't affect results score can be done by using OrderBy and ThenBy.