Conversation
Member
Author
|
@Positron010 I have implemented the custom chromium bookmark loader. Do you want to take a try on this pr? You may need to figure out the data directory of the Vivaldi browser by yourself. |
|
Hi @taooceros, |
Member
Author
Nice to hear that! |
jjw24
requested changes
Sep 26, 2021
Member
jjw24
left a comment
jjw24
left a comment
There was a problem hiding this comment.
- can we align the controls please
- why the two dummy entries?
- can we instead of 'CustomBrowsers', call it 'Load Bookmarks From:' or something else to distinguish from the control above that sets which browser to open bookmarks with.
|
|
||
| var allBookmarks = new List<Bookmark>(); | ||
|
|
||
| //TODO: Let the user select which browser's bookmarks are displayed |
Member
There was a problem hiding this comment.
Suggested change
| //TODO: Let the user select which browser's bookmarks are displayed |
jjw24
added
the
review in progress
Member
|
version bump please |
Member
Author
Always forget it😂 |
Member
Author
|
I will leave #688 in another branch |
jjw24
approved these changes
Oct 11, 2021
jjw24
removed
the
review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will close #694
Refactor Bookmark plugin
TODO: