Dev branch: Fix Bookmark plugin settings browser edit#751
Merged
Conversation
jjw24
changed the title
taooceros
reviewed
Oct 13, 2021
| private readonly List<Bookmark> _bookmarks = new(); | ||
|
|
||
| private void LoadEdgeBookmarks() | ||
| private List<Bookmark> LoadEdgeBookmarks() |
Member
There was a problem hiding this comment.
weird, if that's the case, chrome plugin will not be loaded as well.
I use this way to let the children only provide the path toward the data path, so that it may be abstracted.
Member
|
I am wondering why previous edge bookmark won't be loaded. It is loaded through a field |
jjw24
commented
Oct 14, 2021
Comment on lines
-19
to
+21
| LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge\User Data"), "Microsoft Edge"); | ||
| LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge Dev\User Data"), "Microsoft Edge Dev"); | ||
| LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge SxS\User Data"), "Microsoft Edge Canary"); | ||
| bookmarks.AddRange(LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge\User Data"), "Microsoft Edge")); | ||
| bookmarks.AddRange(LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge Dev\User Data"), "Microsoft Edge Dev")); | ||
| bookmarks.AddRange(LoadBookmarks(Path.Combine(platformPath, @"Microsoft\Edge SxS\User Data"), "Microsoft Edge Canary")); | ||
|
|
||
| return bookmarks; |
Member
Author
There was a problem hiding this comment.
edge bookmark is not loaded due to this, they are not been added, just loaded.
taooceros
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#695