Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immersive editor not displaying due to parent container height #4780

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 14, 2024

Description

makes the ff-layout-plain stretch to max available space

Related Issue(s)

introduced by #4763

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns requested a review from knolleary November 14, 2024 18:10
@cstns cstns self-assigned this Nov 14, 2024
@knolleary knolleary merged commit e173733 into main Nov 14, 2024
9 checks passed
@knolleary knolleary deleted the fix-immersive-editor-height branch November 14, 2024 18:12
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (5278a37) to head (1b3bd26).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4780   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14782    14782           
  Branches     3385     3385           
=======================================
  Hits        11647    11647           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants