Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar redesign follow up #4763

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Sidebar redesign follow up #4763

merged 5 commits into from
Nov 13, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Nov 12, 2024

Description

  • set the sidebar to start collapsed on mobile/tablet
  • the sidebar will now close whenever a navigation link is clicked or whenever it's clicked outside of it
  • also removed a helper class from the ff-app container which set the minimum height to 100vh which clashed with the majority of browsers on smaller devices/tablets/phones where the viewport height included/excluded the toggleable address bar

Related Issue(s)

closes #4762

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (9e7b1e4) to head (5ed30a3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4763   +/-   ##
=======================================
  Coverage   78.79%   78.79%           
=======================================
  Files         311      311           
  Lines       14781    14781           
  Branches     3384     3384           
=======================================
  Hits        11646    11646           
  Misses       3135     3135           
Flag Coverage Δ
backend 78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ake the navbar height into consideration when determining vh
@knolleary
Copy link
Member

Working much better for me.

Only comment is clicking the menu icon whilst the menu is open doesn't close it again. Would be great if, when open, the icon changes to an X and clicking it causes it to close. I discovered I can click outside of the menu to close it, but I expected the menu icon to act as a toggle.

image

@cstns
Copy link
Contributor Author

cstns commented Nov 13, 2024

Managed to get bot changes in!

The left menu was a weird one, the click-outside directive combined with clicking the menu itself was toggling the left drawer so fast that it just remained opened.

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - thanks

@knolleary knolleary merged commit 4309c7f into main Nov 13, 2024
13 checks passed
@knolleary knolleary deleted the sidebar-redesign-follow-up branch November 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar starts opened and does not close when navigating to page
2 participants