Optimise by not cloning key

examples/read_ply_to_structs.rs

@@ -29,7 +29,7 @@ impl ply::PropertyAccess for Vertex {
             z: 0.0,
         }
     }
-    fn set_property(&mut self, key: String, property: ply::Property) {
+    fn set_property(&mut self, key: &String, property: ply::Property) {
         match (key.as_ref(), property) {
             ("x", ply::Property::Float(v)) => self.x = v,
             ("y", ply::Property::Float(v)) => self.y = v,
@@ -46,7 +46,7 @@ impl ply::PropertyAccess for Face {
             vertex_index: Vec::new(),
         }
     }
-    fn set_property(&mut self, key: String, property: ply::Property) {
+    fn set_property(&mut self, key: &String, property: ply::Property) {
         match (key.as_ref(), property) {
             ("vertex_index", ply::Property::ListInt(vec)) => self.vertex_index = vec,
             (k, _) => panic!("Face: Unexpected key/value combination: key: {}", k),

src/parser/mod.rs

@@ -357,7 +357,7 @@ impl<E: PropertyAccess> Parser<E> {
         let mut vals = E::new();
         for (k, p) in &element_def.properties {
             let new_p : Property = self.__read_ascii_property(&mut elem_it, &p.data_type)?;
-            vals.set_property(k.clone(), new_p);
+            vals.set_property(k, new_p);
         }
         Ok(vals)
     }
@@ -480,7 +480,7 @@ impl<E: PropertyAccess> Parser<E> {
 
         for (k, p) in &element_def.properties {
             let property = self.__read_binary_property::<T, B>(reader, &p.data_type)?;
-            raw_element.set_property(k.clone(), property);
+            raw_element.set_property(k, property);
         }
         Ok(raw_element)
     }

src/ply/default_element.rs

@@ -19,8 +19,8 @@ impl PropertyAccess for DefaultElement {
     fn new() -> Self {
         DefaultElement::new()
     }
-    fn set_property(&mut self, key: String, property: Property) {
-        self.insert(key, property);
+    fn set_property(&mut self, key: &String, property: Property) {
+        self.insert(key.to_string(), property);
     }
     fn get_char(&self, key: &String) -> Option<i8> {
         match *get!(self.get(key)) {

src/ply/property.rs

@@ -76,7 +76,7 @@ pub enum Property {
 /// The getters are named in congruence with `PropertyType` and `ScalarType`.
 pub trait PropertyAccess {
     fn new() -> Self;
-    fn set_property(&mut self, _property_name: String, _property: Property) {
+    fn set_property(&mut self, _property_name: &String, _property: Property) {
         // By default, do nothing
         // Sombody might only want to write, no point in bothering him/her with setter implementations.
     }

tests/read.rs

@@ -92,8 +92,8 @@ mod struct_test_1 {
                 z: 0.0,
             }
         }
-        fn set_property(&mut self, key: String, property: ply::Property) {
-            match (key.as_ref(), property) {
+        fn set_property(&mut self, key: &String, property: ply::Property) {
+            match (key.as_str(), property) {
                 ("x", ply::Property::Float(v)) => self.x = v,
                 ("y", ply::Property::Float(v)) => self.y = v,
                 ("z", ply::Property::Float(v)) => self.z = v,
@@ -109,8 +109,8 @@ mod struct_test_1 {
                 vertex_index: Vec::new(),
             }
         }
-        fn set_property(&mut self, key: String, property: ply::Property) {
-            match (key.as_ref(), property) {
+        fn set_property(&mut self, key: &String, property: ply::Property) {
+            match (key.as_str(), property) {
                 ("vertex_index", ply::Property::ListInt(vec)) => self.vertex_index = vec,
                 (k, _) => panic!("Face: Unexpected key/value combination: key: {}", k),
             }