[MIRROR] [Bugfix] Worn lolipops properly consume reagents #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update sweets.dm The lolipops now properly lose reagents when worn in the face slot instead of infinitely giving you its reagents (leading to you inevitably gaining weight.
AnywayFarus
added a commit
that referenced
this pull request
Mar 8, 2024
Iajret
pushed a commit
that referenced
this pull request
May 9, 2024
… on languages (for species without name lists, like Felinids and Podpeople) (#2314) * Random Name Generation refactor, generate random names based on languages (for species without name lists, like Felinids and Podpeople) * Modular adjustments (vox, teshari names) * Update yangyu.dm * Delete language.dm * Remove language.dm override --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
ReezeBL
added a commit
that referenced
this pull request
May 11, 2024
… on languages (for species without name lists, like Felinids and Podpeople) (#3268) * [MIRROR] Random Name Generation refactor, generate random names based on languages (for species without name lists, like Felinids and Podpeople) (#2314) * Random Name Generation refactor, generate random names based on languages (for species without name lists, like Felinids and Podpeople) * Modular adjustments (vox, teshari names) * Update yangyu.dm * Delete language.dm * Remove language.dm override --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com> * now it compiles. --------- Co-authored-by: NovaBot <154629622+NovaBot13@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com> Co-authored-by: ReezeBL <shilk.e82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1334
About The Pull Request
The lolipops now properly lose reagents when worn in the face slot instead of infinitely giving you its reagents (leading to you inevitably gaining weight.)
This was done by adding a second argument to an AddElement() on lolipops that was missing.
Made primarily because someone requested it in feature requests. I will not lose sleep if this is deemed unnecessary
The other reason was learning a bit of how objects are declared in BYOND, which is a success all on its own.
How This Contributes To The Nova Sector Roleplay Experience
Allows you to cosmetically wear a lolipop for entire shifts without "becoming fat" from the endless stream of nutrient that lolipops could give you. Also the absurdity that it gave infinite omnizine is no more.
Proof of Testing
Screenshots/Videos
I really dont know how to show this, so have a 250% sped up clip of me refreshing the reagents variable till it empites. (clip unedited is ~140ish seconds.
https://github.com/NovaSector/NovaSector/assets/161195966/21eddea2-0cb6-4733-a395-58fcd8abbfcb
Changelog
🆑 LordVoidron
fix: Worn lolipops now properly consume their reagents
/:cl: