[MIRROR] Random Name Generation refactor, generate random names based on languages (for species without name lists, like Felinids and Podpeople) #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on languages (for species without name lists, like Felinids and Podpeople) (#2314) * Random Name Generation refactor, generate random names based on languages (for species without name lists, like Felinids and Podpeople) * Modular adjustments (vox, teshari names) * Update yangyu.dm * Delete language.dm * Remove language.dm override --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
Steals-The-PRs
added
Mirroring conflict
AnywayFarus
added a commit
that referenced
this pull request
May 11, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 30, 2024
…uces power cell consumption/storage. [MDB Ignore] [MDB IGNORE] (#3268) * Adds a new power storage type: The Megacell. Drastically reduces power cell consumption/storage. [MDB Ignore] * Fix conflicts * Update internal_computer.dm * Multi chargers * all this other shit * a map that was in the code * some cell defines * multichargers, but better starts at 3.75KW, 625W per tier per capacitor up to 15KW- single cell chargets go from 2.5KW-10KW * fix wall chargers * fix new smes overrides also you didn't see that * colony smes * colony chem dispenser tweaks okay, if anyone's curious the new stats should exactly match the old behavior- able to dispense 250 units off a full charge, and take 50 seconds to fully recharge. Uses a bit less power, because of the changes. It is not however on parity with chem dispensers, which honestly I get the feeling aren't really working as intended right now. I physically couldn't reduce the energy cost to be able to print more than 50 units at a time without upgrading the cell, because it was already at the lower limit of allowed costs. It would probably be fine to buff this in the future if chem dispensers don't get adjusted to their old production speed, but if they do, then this should be good already also chem dispensers use the watt define for "power per unit" costs, that's dumb and silly and I'm rebelling * Removes our modular inducer - TG has one now * mappings * removing our inducer pt 2 * Temporarily adds the fix for TM * buff charger rates about 4x * multi-cells charge rate is per cell (4x faster) * 80% less PDA power drain * fix sustinence dispenser turns out this is important, we can't rely on the normal machine init to spawn us a cell * Revert "Temporarily adds the fix for TM" this has its own PR --------- Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Mal <13398309+vinylspiders@users.noreply.github.com> Co-authored-by: Fluffles <piecopresident@gmail.com>
Iajret
added a commit
that referenced
this pull request
Jul 2, 2024
…uces power cell consumption/storage. [MDB Ignore] (#4153) * [MIRROR] Adds a new power storage type: The Megacell. Drastically reduces power cell consumption/storage. [MDB Ignore] [MDB IGNORE] (#3268) * Adds a new power storage type: The Megacell. Drastically reduces power cell consumption/storage. [MDB Ignore] * Fix conflicts * Update internal_computer.dm * Multi chargers * all this other shit * a map that was in the code * some cell defines * multichargers, but better starts at 3.75KW, 625W per tier per capacitor up to 15KW- single cell chargets go from 2.5KW-10KW * fix wall chargers * fix new smes overrides also you didn't see that * colony smes * colony chem dispenser tweaks okay, if anyone's curious the new stats should exactly match the old behavior- able to dispense 250 units off a full charge, and take 50 seconds to fully recharge. Uses a bit less power, because of the changes. It is not however on parity with chem dispensers, which honestly I get the feeling aren't really working as intended right now. I physically couldn't reduce the energy cost to be able to print more than 50 units at a time without upgrading the cell, because it was already at the lower limit of allowed costs. It would probably be fine to buff this in the future if chem dispensers don't get adjusted to their old production speed, but if they do, then this should be good already also chem dispensers use the watt define for "power per unit" costs, that's dumb and silly and I'm rebelling * Removes our modular inducer - TG has one now * mappings * removing our inducer pt 2 * Temporarily adds the fix for TM * buff charger rates about 4x * multi-cells charge rate is per cell (4x faster) * 80% less PDA power drain * fix sustinence dispenser turns out this is important, we can't rely on the normal machine init to spawn us a cell * Revert "Temporarily adds the fix for TM" this has its own PR --------- Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Mal <13398309+vinylspiders@users.noreply.github.com> Co-authored-by: Fluffles <piecopresident@gmail.com> * ff stuff --------- Co-authored-by: NovaBot <154629622+NovaBot13@users.noreply.github.com> Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com> Co-authored-by: Mal <13398309+vinylspiders@users.noreply.github.com> Co-authored-by: Fluffles <piecopresident@gmail.com> Co-authored-by: Iajret <HellDog15@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2314
Original PR: tgstation/tgstation#83021
About The Pull Request
This PR moves random name generation for species onto their languages.
What does this mean?
For species with a predefined name list, such as Lizards and Moths, nothing.
For species without predefined name lists, such as Felinids, their names will now be randomly generated from their language's syllables.
(In the prefs menu:)
Why?
Misc:
species_prototypeglobal, uses it in a lot of places in prefs code.GLOB.species_listinit via the global definesChangelog
🆑 Melbert
refactor: Random Name Generation has been refactored. Report any instances of people having weird (or "Unknown") names.
qol: Felinids, Slimepeople, Podpeople, and some other species without defined namelists now automatically generate names based on their primary language(s).
qol: More non-human names can be generated in codewords (and other misc. areas) than just lizard names.
/:cl: