This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Fix incorrect menu on second highlight attempt #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #170.
I don't get what the logic is behind this. Why is
createMenu
called on menu dismiss, and not on menu show? Is it a sort of pre-rendering? What does thesetMenuVisible(true, andRect: rect)
call do? As it clearly doesn't show the menu, as it is being dismissed at that point.Nonetheless, it looks like, somehow, on long tap, the correct menu appears all the time, so there's no need to force the "share" menu.