Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Fix incorrect menu on second highlight attempt #177

Merged
merged 1 commit into from
Dec 5, 2016

Conversation

revolter
Copy link
Member

@revolter revolter commented Nov 8, 2016

This fixes #170.

I don't get what the logic is behind this. Why is createMenu called on menu dismiss, and not on menu show? Is it a sort of pre-rendering? What does the setMenuVisible(true, andRect: rect) call do? As it clearly doesn't show the menu, as it is being dismissed at that point.

Nonetheless, it looks like, somehow, on long tap, the correct menu appears all the time, so there's no need to force the "share" menu.

@hebertialmeida hebertialmeida self-assigned this Nov 15, 2016
@alexliubj
Copy link

alexliubj commented Dec 2, 2016

Yes, this is a good catch. It definitely fixed the second popup menu issue right after highlighted a sentence.

@revolter
Copy link
Member Author

revolter commented Dec 2, 2016

@alexliubj, You can use my fork until this gets merged using pod 'FolioReaderKit', :git => 'https://github.com/revolter/FolioReaderKit.git', :commit => '90ce3882'

@hebertialmeida hebertialmeida merged commit 097d0b1 into FolioReader:master Dec 5, 2016
@hebertialmeida
Copy link
Member

Sorry guys, I am really busy these days, thanks @revolter for the PR and it is merged on master now.

@revolter revolter deleted the patch-2 branch December 5, 2016 13:42
@revolter
Copy link
Member Author

revolter commented Dec 5, 2016

I understand. When you'll have time, some answers to my original questions would help too.

@revolter
Copy link
Member Author

revolter commented Dec 9, 2016

This was reverted by eb72882 as per this comment.

@alexliubj
Copy link

I think I am still experiencing this issue. And advise to fix it? The colour selection menu (also the menu with deletion) still popup periodically but the menu with 'highlight' is expected when the normal text is selected at the first time.

@alexliubj
Copy link

@revolter Did you get a solution for this?
Thanks,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants