Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

Commit

Permalink
Back menu option
Browse files Browse the repository at this point in the history
  • Loading branch information
@hebertialmeida
hebertialmeida committed Dec 8, 2016
1 parent 4a609cb commit eb72882
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/FolioReaderWebView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ open class FolioReaderWebView: UIWebView {
isUserInteractionEnabled = false
isUserInteractionEnabled = true

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Dec 9, 2016

Member

Why is this duplicated?

This comment has been minimized.

Sign in to view

Copy link
@hebertialmeida

hebertialmeida Dec 9, 2016

Author Member

This is a hack to Force remove text selection

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Dec 9, 2016 •
edited
Loading

Member

Added #191 that "fixes" this.

createMenu(options: false)

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Dec 9, 2016 •
edited
Loading

Member

Why did you make this change? It looks like it reverts #177 😢

This comment has been minimized.

Sign in to view

Copy link
@hebertialmeida

hebertialmeida Dec 9, 2016

Author Member

I reverted because #186, This menu is very complex and we did a big migration some days ago. I am aware that needs to be improved, but will take more time. Maybe I will write a new menu and do not use the native one because of too many hacks.

I also could not simulate any problem with createMenu(options: true), just with createMenu(options: true). Maybe

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Dec 9, 2016

Member

Are you saying that you can't reproduce #170?

This comment has been minimized.

Sign in to view

Copy link
@hebertialmeida

hebertialmeida Dec 9, 2016

Author Member

Yes.

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Dec 9, 2016

Member

That's weird as it's easily reproducible. I'll try to take a screen recording of it, maybe you didn't understand it well from the comments 😄

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Jan 11, 2017 •
edited
Loading

Member

Done: https://dl.dropboxusercontent.com/u/29987662/Screencasts/folioreader-issue-170.mov

This comment has been minimized.

Sign in to view

Copy link
@hebertialmeida

hebertialmeida Jan 12, 2017

Author Member

Yeah need to spent a time reviewing this menu... 😭😭😭

This comment has been minimized.

Sign in to view

Copy link
@revolter

revolter Jan 12, 2017 •
edited
Loading

Member

We could discuss this on Gitter. Firstly, I'd like for you to explain to me how it works, so I have a better understanding of it. And also, if you can reproduce #186's crash, that would be great.
createMenu(options: true)
setMenuVisible(true, andRect: rect)

// Persist
Expand Down

0 comments on commit eb72882

Please sign in to comment.