This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Fixed code style #191
Merged
Fixed code style #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted duplicate "hack" into a clearly named function. Previously, not all instances had the explanation comment, and its side effect was not clear.
hebertialmeida
approved these changes
Dec 9, 2016
hebertialmeida
approved these changes
Dec 9, 2016
| // Forces text selection clearing | ||
| // @NOTE: this doesn't seem to always work | ||
|
|
||
| self.isUserInteractionEnabled = false |
There was a problem hiding this comment.
Don't need to use self here.
| isUserInteractionEnabled = false | ||
| isUserInteractionEnabled = true | ||
|
|
||
| self.clearTextSelection() |
There was a problem hiding this comment.
Don't need to use self here.
There was a problem hiding this comment.
I know, but it's more consistent and clear this way.
There was a problem hiding this comment.
I am personally going by this answer:
I would prefer to keep using self whenever I'm using a property to omit these misunderstandings.
What do you think?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted duplicate "hack" into a clearly named function. Previously, not all
instances had the explanation comment, and its side effect was not clear.