Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizer Touch events #466

Open
ShaMan123 opened this issue Feb 6, 2018 · 5 comments
Open

Resizer Touch events #466

ShaMan123 opened this issue Feb 6, 2018 · 5 comments

Comments

@ShaMan123
Copy link

I downloaded an instance of croppie a week ago. The touch resize events didn't work. After inspection I found that the code was missing but here I see it.

Is this new?

` if (vr) {
vr.addEventListener('mousedown', mouseDown);
vr.addEventListener('touchstart', mouseDown);
}

    if (hr) {
        hr.addEventListener('mousedown', mouseDown);
        hr.addEventListener('touchstart', mouseDown);
    }`
@atroppe
Copy link

atroppe commented Jul 20, 2018

I am also struggling with this issue. I came across a pr in which these lines of code were added to the croppie library, but it does not seem to be present in the latest released version.

Any update as to which version of croppie is needed in order to support touch events?

@ShaMan123
Copy link
Author

ShaMan123 commented Jul 20, 2018 via email

@atroppe
Copy link

atroppe commented Jul 20, 2018

I tried editing my local copy but it did not work.
I am using the angular package referenced above, so I suspect I would need the angular package to support the version released after the change was made to the croppie library.

@ShaMan123
Copy link
Author

check out my PR
changed files:
croppie.js
croppie.css

This is an old version though. It's been a long time since I worked with it. Hope it helps.
I Have no clue about angular.

@CharlieScarver
Copy link

CharlieScarver commented Aug 21, 2018

I too faced this problem.
I just updated to the latest version of croppie @2.6.2 and the touch event code is there and works on a tablet. 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants