[Prefix] Add an option to prefix for all user agent #552
Conversation
|
I have just realized that we can use https://github.com/rofrischmann/radium-plugin-prefix-all for the same use case. Do you still want this PR? |
| const style = getElement(output, 'style'); | ||
| expectCSS(style, ` | ||
| div { | ||
| -ms-transform: rotate(90); |
There was a problem hiding this comment.
This doesn't seem right, I would have expected transform, -webkit-transform and others to be here as well.
There was a problem hiding this comment.
Indeed, I had no way to know the output order of the prefixes with the Symbol fail. Fixed!
|
Thank you for the PR! The plugin, while nice for basic cases, is not quite ideal, because the prefixer isn't fully pluggable. It is used directly by keyframes, style, and media queries, so none of those would be affected by swapping the plugin. The only thing your PR is missing is support for keyframes prefix, more details in the comment. |
My use case for this, is to prefix for all user agent on the server side and only for the browser agent on the client side. As pointed out here facebook/react#1979 I think that it's a very good trade-off. This allow me to remove the user agent from the memoization I use on the `renderToString` method. The test fails because of robinweser/inline-style-prefixer#58. I'm gonna address it. Fix #546.
|
We'll have to wait until the fix for robinweser/inline-style-prefixer#58 is release to merge this. |
|
|
My use case for this, is to prefix for all user agent on the server side
and only for the browser agent on the client side. As pointed out here facebook/react#1979
I think that it's a very good trade-off.
This allow me to remove the user agent from the memoization I use on the
renderToStringmethod.The test fails because of robinweser/inline-style-prefixer#58.
I'm gonna address it.
Fix #546.