Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES6] Remove the need for the Symbol polyfill #59

Merged
merged 1 commit into from
Jan 24, 2016
Merged

[ES6] Remove the need for the Symbol polyfill #59

merged 1 commit into from
Jan 24, 2016

Conversation

oliviertassinari
Copy link
Contributor

Fix #58 and should fix my test here FormidableLabs/radium#552.

@rofrischmann Feedback welcomed.

@oliviertassinari oliviertassinari changed the title [ES6] Remove the need for the Symbole polyfill [ES6] Remove the need for the Symbol polyfill Jan 24, 2016
@oliviertassinari
Copy link
Contributor Author

I'm not sure to understand why the test fails. No CODECLIMATE_REPO_TOKEN found?

robinweser pushed a commit that referenced this pull request Jan 24, 2016
[ES6] Remove the need for the Symbol polyfill
@robinweser robinweser merged commit e97c1d7 into robinweser:master Jan 24, 2016
@robinweser
Copy link
Owner

Huh, that should not be an issue. Well, I can see that there's everything fine. Thanks for your help :)

@oliviertassinari oliviertassinari deleted the es6-symbole branch January 24, 2016 19:22
@oliviertassinari
Copy link
Contributor Author

@rofrischmann Thanks! I wasn't sure you where going to merge it 😁. That's debatable.

I'm wondering why the npm run test works on this project and not on the radium one.
I can't find any babel-polyfill installed here. Could this be because of babel@5 (here) / babel@6 (radium)?

@robinweser
Copy link
Owner

True. I'd normally not merge something that breaks the tests, but in this case it is just the code quality tool that fails, perhaps because I've set up the repo, but that'd be ridiculous.

I am not sure if Babel 5 (stage 0) covered the polyfill as well, but could the reason. I know that using babel-node automatically uses the polyfill. Perhaps --compilers js:babel/register as a mocha argument uses these too.

@ianobermiller
Copy link
Contributor

FWIW I definitely prefer Object.keys and avoiding for loops whenever possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefixAll] Throw Can't find variable: Symbol
3 participants