Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing console or window crashes the editor #283

Closed
S33G opened this issue Oct 26, 2021 · 4 comments · Fixed by #288
Closed

Typing console or window crashes the editor #283

S33G opened this issue Oct 26, 2021 · 4 comments · Fixed by #288

Comments

@S33G
Copy link

S33G commented Oct 26, 2021

I noticed something when doing some UAT within our project. At first, we assumed it was within our implementation, however, since testing the live demo - the issue persists there too.

Steps to recreate:

  1. Visit: https://react-live.netlify.app/
  2. Nullify any editor
  3. Type console or window
  4. Upon finishing typing, the entire page will crash and throw an error to the console

In development mode, more information is shown in the console.

I'm happy to provide more information if needed.

Thanks
Selection_003

@ryan-roemer
Copy link
Member

Confirmed. This does crash the whole page / app.

@S33G
Copy link
Author

S33G commented Jan 18, 2022

Amazing, thank you @AaronPowell96.

@jpdriver, any idea when a new version will be released containing this fix, please?

@jpdriver
Copy link
Contributor

this is available in react-live@2.4.1 or more recent. at this stage you can just yarn add react-live and it'll be there

@S33G
Copy link
Author

S33G commented Jan 27, 2022

Updated our project.

Thanks all involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants