fix #283: Verify valid element before rendering #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great! thanks so much for this @AaronPowell96 |
This was referenced Jan 22, 2022
This was referenced Feb 1, 2022
1 task
This was referenced Mar 7, 2022
1 task
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/FormidableLabs/react-live/issues/283
Add a React.isValidElement check before rendering to the live playground, preventing a full window crash when entering non-valid child objects such as console, window, document.
See the difference in changes below:
Before - https://www.loom.com/share/ba67749226a546129caa8cc7e33eae09
After - https://www.loom.com/share/0583ebbaaf6c4ccf8f69eaca1a35c9ad
resolves #283