(breaking) - Remove pollInterval option from urql #1374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #531
Summary
This PR removes the
pollInterval
option from@urql/core
and all bindings. Generally it isn't hard to replacepollInterval
in user-land with even more correct behaviour, as it can ultimately read the results of the bindings and react to those accordingly.React / Preact replacement
This just demonstrates that it's rather simple to replace the implementation in React-land.
NOTE re #531: It's worth noting that this PR doesn't resolve the issue explicitly, however we see it as much easier to implement effects in user-land that call
executeQuery
to refresh the results on an interval.Set of changes
pollInterval
from@urql/core
pollInterval
fromuseQuery
inurql
pollInterval
fromuseQuery
in@urql/preact
pollInterval
fromuseQuery
in@urql/vue