Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) - Polled queries are no longer supported #1669

Closed
wants to merge 1 commit into from

Conversation

bartenra
Copy link
Contributor

I saw that polling is supported in the docs, but couldn't find anything when searching for it. Then I found out the feature was actually removed.

I think the docs should be updated to reflect this change.

In case you want to include snippets in the individual docs of how to do polling, the Vue equivalent of @kitten's React snippet would be:

let { data, fetching, executeQuery } = useQuery(...);

const id = setInterval(() => {
  if (!fetching)
    executeQuery({ requestPolicy: 'network-only' });
}, 1000);

onBeforeUnmount(() => {
  clearInterval(id);
});

I am happy to add the React and Vue snippets for polling, however, someone else would have to chip in for svelte since I'm not familiar with it.

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2021

⚠️ No Changeset found

Latest commit: 124fbf9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -43,7 +43,7 @@ All features are marked to indicate the following:
| Devtools | ✅ | ✅ | ✅ |
| Subscriptions | ✅ | ✅ | ✅ |
| Client-side Rehydration | ✅ | ✅ | ✅ |
| Polled Queries | | ✅ | ✅ |
| Polled Queries | 🛑 | ✅ | ✅ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! 🙌 The only thing I'd propose is to use "🔶" because we removed the option since it requires very little code to implement in userland, i.e. "🔶" standing for "Supported and documented, but requires custom user-code to implement."

I believe what we need to do though is to make sure to readd it to the docs with our suggested code, which we haven't done yet because it'd be grouped with docs on the "Request Policy" and "Refocus" exchanges, which we in turn wanted to merge into a single one first

Suggested change
| Polled Queries | 🛑 |||
| Polled Queries | 🔶 |||

@kitten kitten changed the title [DOCS] Polled queries are no longer supported (docs) - Polled queries are no longer supported May 25, 2021
@kitten kitten closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants