-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font-variant other than normal #2171
Comments
Unable to reproduce: http://jsfiddle.net/tagliala/pzELF/ Could it be related to #862 and optimizeLegibility? |
@tagliala I was UNABLE to repo as well on your jsfiddle- but had my collegue hit that and it DID repo on both instances (span and h4) I CAN repo in moblie Chrome (android) v 30.0.1599.82 both instances |
Confirmed on chrome mobile beta for android. I will send a mail to dave, don't know if this should be documented or included in the base class of 4.0 |
@tagliala OK thanks just wanted to enhance a great product! PS Can you come up with an instance of when my fix might cause unwanted results. I cant think of any since the whole point of this font is to display icons/glyphs - a font variant should never come into play in my mind. |
Able to reproduce with glyphicons on my desktop (chrome 30, w7 x64)... http://jsfiddle.net/tagliala/vx6mr/1/ I'm going to submit a bug to chromium |
@ccarns can you please try out Chrome Canary 32.0.1674.2 ? |
It's fine in chromium 32, closing here! It's also documented in https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting |
This is solved in 4.2.0 Removing the following from the troubleshooting guide: font-variant (Small caps)If you are using /* FA 4.0.0 and newer */
.fa {
font-variant: normal;
}
/* FA 3.2.1 and older */
[class^="icon-"],
[class*=" icon-"] {
font-variant: normal;
} (more info on #2171) |
Discovered a bug/issue that only raises its head on Chrome. If your icon is wrapped inside of style where the font-variant is small-caps (probably others options break as well) the intended icon will do the famous box icon OR some other unwanted icon.
FIX:
Hope this saves someone else the 2 hours me and my co-worker spent in the weeds tracking down the cause.
PS we are still confused but I could not repo it on my box and he could - even though we had the exact same Chrome version AND the exact same hardware and OS.
The text was updated successfully, but these errors were encountered: