Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-variant other than normal #2171

Closed
ccarns opened this issue Oct 18, 2013 · 9 comments
Closed

font-variant other than normal #2171

ccarns opened this issue Oct 18, 2013 · 9 comments
Milestone

Comments

@ccarns
Copy link

ccarns commented Oct 18, 2013

Discovered a bug/issue that only raises its head on Chrome. If your icon is wrapped inside of style where the font-variant is small-caps (probably others options break as well) the intended icon will do the famous box icon OR some other unwanted icon.

FIX:

    [class^="icon-"], [class*=" icon-"] {
      font-variant: normal !important;
    }

Hope this saves someone else the 2 hours me and my co-worker spent in the weeds tracking down the cause.

PS we are still confused but I could not repo it on my box and he could - even though we had the exact same Chrome version AND the exact same hardware and OS.

@tagliala
Copy link
Member

Unable to reproduce: http://jsfiddle.net/tagliala/pzELF/

Could it be related to #862 and optimizeLegibility?

@ccarns
Copy link
Author

ccarns commented Oct 18, 2013

@tagliala I was UNABLE to repo as well on your jsfiddle- but had my collegue hit that and it DID repo on both instances (span and h4)

I CAN repo in moblie Chrome (android) v 30.0.1599.82 both instances

screenshot_2013-10-18-14-51-45

@tagliala
Copy link
Member

Confirmed on chrome mobile beta for android.

I will send a mail to dave, don't know if this should be documented or included in the base class of 4.0

@ccarns
Copy link
Author

ccarns commented Oct 18, 2013

@tagliala OK thanks just wanted to enhance a great product!

PS Can you come up with an instance of when my fix might cause unwanted results. I cant think of any since the whole point of this font is to display icons/glyphs - a font variant should never come into play in my mind.

@tagliala
Copy link
Member

I'm confident that neither your fix nor the other one will affect FA's functionalities, but fixing #2131 , #862 and this one in the base class adds 3 extra rules that are only needed in some edge circumstances.

I will talk point this out to Dave and Rob, then it will be their call

@tagliala
Copy link
Member

Able to reproduce with glyphicons on my desktop (chrome 30, w7 x64)...

http://jsfiddle.net/tagliala/vx6mr/1/

I'm going to submit a bug to chromium

@tagliala
Copy link
Member

@ccarns can you please try out Chrome Canary 32.0.1674.2 ?

@tagliala
Copy link
Member

It's fine in chromium 32, closing here!

It's also documented in https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting

@tagliala tagliala added this to the 4.2.0 milestone Sep 16, 2014
@tagliala
Copy link
Member

This is solved in 4.2.0


Removing the following from the troubleshooting guide:

font-variant (Small caps)

If you are using font-variant: small-caps;, according to your Font Awesome version, please add to your stylesheets:

/* FA 4.0.0 and newer */
.fa {
  font-variant: normal;
}

/* FA 3.2.1 and older */
[class^="icon-"],
[class*=" icon-"] {
  font-variant: normal;
}

(more info on #2171)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants