-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Awesome 4.0.1 -- IE8 needs a font url fix #2324
Comments
Sorry I should have been more explicit -- it does work fine on your server. I think it's a server specific issue with parsing invalid urls. If you review the url format though -- that's not technically formatted properly. I think the update suggested would fix the url for server frameworks that use url validation mechanisms. |
I think this should be done, reopening |
@davemaple please wait for a pull request, there is still no proper branch to push against glyphicons have the same issue, right? You could consider to make a pull request to bootstrap too |
@davemaple can you please also check that this change will not affect IE9 and IE10 ? |
yes. testing now. |
works fine in both IE9 and IE10. |
Fine, thanks! If you see the Files that needs this patch are: https://github.com/FortAwesome/Font-Awesome/blob/master/src/assets/font-awesome/scss/_path.scss#L7 and https://github.com/FortAwesome/Font-Awesome/blob/master/src/assets/font-awesome/less/path.less#L7 (the ones in PS: Glyphicons should not be affected, since there is no version number |
I'll fold this into 4.0.2 right now. No need for a PR. Thanks as always, @tagliala. |
Thanks Dave! |
Added into 4.0.2-wip. |
Confirmed. I'm not sure why it works for me using playframework but I can http://stackoverflow.com/questions/8050640/how-does-iefix-solve-web-fonts-loading-in-ie6-ie8 On Mon, Nov 4, 2013 at 7:30 PM, Ben Bodenmiller notifications@github.comwrote:
Respectfully, David Maple This email and any files transmitted with it are confidential and intended |
It is working for me here though in both IE8 and IE9 ... I'm not seeing what the syntactical difference is. |
Regardless ... I've broken the build for you guys :( and this needs to get reverted. All apologies. |
Oh man I'm really sorry. Having read the SO post more carefully I see why now. Playframework automatically minifies all the CSS so the whole font declaration is on one line. Consequently the very presence of the ? causes IE to stop parsing the rest of the declaration. In a non-minified version the url hack is still needed. |
@davemaple We could document this in our troubleshooting guide Can you please edit this wiki: https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting reporting your experience and what to do? |
Definitely. Let me spend a little more time tracking down the exact nature of the issue as experienced on Playframework and then I'll add an entry. Again, my apologies for breaking your build. |
@davemaple don't worry too much, (sh)it happens! Since that url is not valid (I'm reading here: http://tools.ietf.org/html/std66)
We can blame someone else :) |
I still can't get the icons to load in IE8 in certain enterprise configurations. Any idea what setting may be preventing this? |
@bbodenmiller what did you try? mime types? proper url? |
Check the Content-Type header when requesting the .eot font directly and verify that your server is returning application/vnd.ms-fontobject or application/octet-stream. Those both seem to work for me. |
Appears this is a result of IEs settings being configured to block font downloading. Anyone get font-awesome working with typeface.js, cufon.js, or any other JavaScript methods of downloading the font? |
I am in the same boat with font downloading being blocked. I have looked at this with not a lot of success yet, has anyone else in this situation? http://stackoverflow.com/questions/7973421/detect-if-font-download-in-ie-is-enabled |
That was my issue but unfortunately I cannot change the IE security settings for the whole company. Supposedly one can load Font-Awesome via js but I haven't got it working yet. |
@bbodenmiller that would be handy. Do you have a link to how to do this? |
That's exactly what I have been trying to figure out too. I got to where you can check if you can download the font, and if not, use the images we made as replacements. But that sucks. Would like to figure out how to load via ajax/js. From: Josh Schreuder <notifications@github.commailto:notifications@github.com> @bbodenmillerhttps://github.com/bbodenmiller that would be handy. Do you have a link to how to do this? Reply to this email directly or view it on GitHubhttps://github.com//issues/2324#issuecomment-34708614. |
@ehoffman73 @bbodenmiller Same situation here -- Any luck with finding a script to load Font-Awesome via ajax/js? - Thanks |
Please open a new issue, this one is about that particular framework |
Hi guys, I know that this issue was closed, but I had the same problem on IE8 for Font-Awesome 4.0.3, and I just want to share the workaround I used. I just added the html5.js script on my project <!--[if lt IE 9]>
<script src="http://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]--> I saw that solution somewhere for another font library and saw that it was used on the homepage for FontAwesome 3.2.1 and didn't see that workaround neither on Troubleshooting |
@cefigueiredo thanks for sharing this, but IE8 has random issues with I was "lucky" enough to reproduce the bug on the following website: http://tagliala.github.io/vectoriconsroundup/ which, as you can see here: https://github.com/tagliala/vectoriconsroundup/blob/gh-pages/index.html#L90, includes that script |
still has a weird bug, even with the html5.js addition.
|
@drKnoxy sorry but this is a random issue with IE8 and pseudo elements and we can't fix this. |
Was there any resolution with this? I've tried just about everything and still can't get the icons to show up on IE 8. |
@Showtimes IE8 works. There are random issues with pseudo elements, but there is not a fix and they are random. If you can't see icons at all, there is a problem with your configuration. PS: this thread is about an url fix that we had to revert. If anyone is concerned about IE8 please open new issues. Probably we need to document this random stuff about IE8 |
@tagliala , this isn't just a random issue, it is a real one, and it does show up even without IE configured to block font downloads, and with the proper tags to force IE8 out of Compatibility Mode. For what it's worth, this is what worked for me: http://stackoverflow.com/a/10557782 I think it should be in the troubleshooting wiki. |
if we are using |
@davemaple please if u can have any suggestions |
@kunjbiharipandey you should consider stackoverflow for support request. Please also take a look at our troubleshooting guide: https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting If you think there is a bug with fontawesome, please open a new request providing a fiddle showing the issue |
Locking here, this change was reverted in FA 4.0.3 via e07edeb because of #2324 (comment) |
This one should be real simple to fix. By default fonts aren't rendering on IE8. There is a little tweak needed to the #iefix url:
should be:
I can create a pull request if that's helpful. Thanks!
The text was updated successfully, but these errors were encountered: