Merge pull request #1797 from France-ioi/fix-too-many-redirections

Fix too many redirections

.eslintrc.js

@@ -109,6 +109,7 @@ module.exports = {
       'ignoreStatic': true
     }],
     '@typescript-eslint/no-explicit-any': 'off',
+    '@ngrx/no-store-subscription': 'off'
   },
   overrides: [
     {

src/app/items/item-by-id.component.ts

@@ -224,7 +224,6 @@ export class ItemByIdComponent implements OnDestroy, BeforeUnloadComponent, Pend
       this.itemRouter.navigateTo({ ...route, answer: undefined });
     }),
 
-    // eslint-disable-next-line @ngrx/no-store-subscription
     this.store.select(fromItemContent.selectActiveContentRoute).subscribe(route => {
       if (route) {
         // just publish to current content the new route we are navigating to (without knowing any info)
@@ -239,7 +238,6 @@ export class ItemByIdComponent implements OnDestroy, BeforeUnloadComponent, Pend
 
     // on datasource state change, update the current content page info
     this.itemState$.pipe(readyData()).subscribe(data => {
-      this.hasRedirected = false;
       this.currentContent.replace(itemInfo({
         breadcrumbs: {
           category: itemBreadcrumbCat,
@@ -268,18 +266,21 @@ export class ItemByIdComponent implements OnDestroy, BeforeUnloadComponent, Pend
 
     this.breadcrumbService.resultPathStarted$.subscribe(() => this.currentContent.forceNavMenuReload()),
 
-    this.itemState$.pipe(
-      filter(s => s.isError),
-    ).subscribe(state => {
+    this.store.select(fromItemContent.selectActiveContentBreadcrumbs).subscribe(state => {
+      if (state.isError) this.currentContent.clear();
+
       // If path is incorrect, redirect to same page without path to trigger the solve missing path at next navigation
-      if (errorHasTag(state.error, breadcrumbServiceTag) && (errorIsHTTPForbidden(state.error) || errorIsHTTPNotFound(state.error))) {
+      if (
+        state.isError &&
+        errorHasTag(state.error, breadcrumbServiceTag) &&
+        (errorIsHTTPForbidden(state.error) || errorIsHTTPNotFound(state.error))
+      ) {
         if (this.hasRedirected) throw new Error('Too many redirections (unexpected)');
         this.hasRedirected = true;
         const { contentType, id, answer } = this.getItemRoute();
         if (!id) throw new Error('Unexpected: item id should exist');
         this.itemRouter.navigateTo({ contentType, id, answer }, { navExtras: { replaceUrl: true } });
-      }
-      this.currentContent.clear();
+      } else this.hasRedirected = false;
     }),
 
     combineLatest([ this.itemRoute$, this.itemState$.pipe(startWith(undefined)) ]).pipe(

src/app/services/crash-reporting.service.ts

@@ -19,7 +19,6 @@ export class CrashReportingService {
   init(): void {
     this.userSessionService.session$.subscribe(session => setUser(session ? { id: session.groupId, username: session.login } : null));
 
-    // eslint-disable-next-line @ngrx/no-store-subscription
     this.store.select(fromObservation.selectObservedGroupId).subscribe(g => addBreadcrumb({
       category: 'group-watching',
       level: 'info',