Fix too many redirections #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bid it does not apply to us)
smadbe
force-pushed
the
fix-too-many-redirections
branch
from
6c2cc05 to
1f72275
Compare
|
E2e tests are not passing, but that looks like the usual problem. Isn't it? |
Iloveall
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had in the crash reporting some "Too many redirections (unexpected)" reported from time to time for months. That looked like a bad smell as it is "unexpected".
Actually, the previous condition based on
this.itemState$.pipe(was wrong as we may two successive "subscribe" without being the breadcrumbs failing twice, but just failing once and having another part of the state (item, results) changing. So it was wrongly considered as two failures.Also, now,
hasRedirectedis resetted as soon as breadcrumb returns something else than a forbidden/not-found response, not just with a full success of the state.