Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to suggest installing dependencies in order to build vignettes #94

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Update README.md to suggest installing dependencies in order to build vignettes #94

merged 3 commits into from
Sep 4, 2024

Conversation

kelliemac
Copy link
Contributor

@kelliemac kelliemac commented Aug 23, 2024 •
edited
Loading

Update README.md to suggest installing dependencies in order to build vignettes

Related to #88

@kelliemac kelliemac self-assigned this Aug 23, 2024
@kelliemac kelliemac requested a review from slager August 23, 2024 23:03
slager
slager approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@slager slager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with or without the following suggestion: It could be nice to mention that the new method can sometimes auto-upgrade dependencies, and mention using the "upgrade" argument if user wants finer control over whether that happens.

@kelliemac
Copy link
Contributor Author

thanks @slager! I added a note about that.

@kelliemac kelliemac merged commit 8858847 into develop Sep 4, 2024
6 checks passed
@kelliemac kelliemac deleted the update-readme-vignette-building branch September 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slager slager slager approved these changes

Assignees

@kelliemac kelliemac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelliemac @slager