Proof update srm #1080
Merged
Proof update srm #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated text for server, validate, and submit sections
tefirman
requested changes
Oct 29, 2024
Co-authored-by: Taylor Firman <37599954+tefirman@users.noreply.github.com>
tefirman
requested changes
Nov 2, 2024
There was a problem hiding this comment.
New screenshots look phenomenal!!! This might already be on your radar, but it looks like a couple haven't been updated yet:
- Red logout button: proof_101_shinyapp_logged_in.png
- Troubleshooting: proof_101_shiny_app_troubleshoot_3.png
I can definitely approve and merge if you want to incorporate these changes and update those two later, just let me know, but might be easier to incorporate them in this one real quick?
|
Now remembering that Troubleshooting is 100% my section, really sorry... 🤦 I'll get this merged in and add my updates in a separate section. Thanks Sonu! |
tefirman
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.