Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title not visible on white background videos #1348

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue May 27, 2021 · 0 comments · Fixed by #4978
Closed

Title not visible on white background videos #1348

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue May 27, 2021 · 0 comments · Fixed by #4978
Labels
enhancement New feature or request

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Is your feature request related to a usage problem (not a bug)? Please describe.
i saw the implementation of #694 while watching this video:
https://youtu.be/ipJb4mB5bMA

It seemed fine in the beginning of the video, but when a white background went by in the video and i move my mouse i couldn't see the title anymore.

Describe the solution you'd like to see implemented
The title should be clear to see at all times: Add a medium transparent darker overlay on the top of the video, similar to YouTube.

Describe alternatives you've considered
None.

Video

6z1kgD1FSU.mp4

Additional context
Comment from @GilgusMaximus:
So for the visibility of the video title, a simple solution like adding a black border around the text would be an easy fix.
Because recognizing where the video is light and dark for all characters could slow down the app significantly for every frame of the video.
Another possibility would be to add a medium transparent darker overlay on the top of the video, similar to YouTube. This allows the white text to be visible at any time as well.

Regarding the font size, this should be taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant