-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title of vid in fullscreen #694
Comments
It would be ideal if a videojs plugin for that exists, or one is created. We are definitely open for either direct implementations (in case Videojs allows this already) or the setup of a VideoJS plugin. |
Could I try and use this plugin for the issue? |
Hi. |
Please do! |
Hello, I found this issue in the overlay closed issues that says I need to include the overlay css, but doing so does not fix the problem. I also found this issue that says I need to append the overlay to the videoPlayers containing div, which I think is the Any help would be greatly appreciated. |
Hi, so it would be great if you can create a PR and mark it as draft and label it with 'Help wanted'. Then everyone sees that a new PR is available and can take a look. Because we are also not so invested into VideoJS plugins, it might take a bit until help arrives. But great work so far that it is working on some videos already. Getting something to work partially is always the first step towards fixing up the last bits 👍 |
Hey @GilgusMaximus , I made a little more progress since last time but there's still one nagging issue. I made a draft PR like you suggested but I cannot change the labels to it. Could you please add the |
I added the tag for you. I'll review / help out sometime tomorrow to help finish up the PR. |
Please open up a new issue for this bug to make it visible to everyone. |
Is your feature request related to a usage problem (not a bug)? Please describe.
In YT i noticed when in fullscreen and move ur mouse in any direction u will see the Title of the vid in the left top cornor. It bugs me it is not there. For example if i watch a music vid in fullscreen of an unknown artist and i want to see who it is or what the name of the song is then i have to leave fullscreen.
Describe the solution you'd like to see implemented
I would like this to be implemented as the same visual way like YT.
Describe alternatives you've considered
None
Screenshots
None
Additional context
None
The text was updated successfully, but these errors were encountered: