Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title of vid in fullscreen #694

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Oct 19, 2020 · 9 comments · Fixed by #789
Closed

Title of vid in fullscreen #694

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Oct 19, 2020 · 9 comments · Fixed by #789
Assignees
Labels
enhancement New feature or request

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Is your feature request related to a usage problem (not a bug)? Please describe.
In YT i noticed when in fullscreen and move ur mouse in any direction u will see the Title of the vid in the left top cornor. It bugs me it is not there. For example if i watch a music vid in fullscreen of an unknown artist and i want to see who it is or what the name of the song is then i have to leave fullscreen.

Describe the solution you'd like to see implemented
I would like this to be implemented as the same visual way like YT.

Describe alternatives you've considered
None

Screenshots
None

Additional context
None

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the enhancement New feature or request label Oct 19, 2020
@GilgusMaximus
Copy link
Contributor

It would be ideal if a videojs plugin for that exists, or one is created.

We are definitely open for either direct implementations (in case Videojs allows this already) or the setup of a VideoJS plugin.

@TDDR
Copy link
Contributor

TDDR commented Nov 5, 2020

Could I try and use this plugin for the issue?
https://github.com/brightcove/videojs-overlay

@GilgusMaximus
Copy link
Contributor

Hi.
So the license looks fine and if you can get this plugin working nicely, that'd be great :)
I'd assign you to this issue if that is okay?

@TDDR
Copy link
Contributor

TDDR commented Nov 5, 2020

Please do!

@TDDR
Copy link
Contributor

TDDR commented Nov 9, 2020

Hello,
I have made some progress but am stuck on the last detail. As it stands the overlay is stuck in the background. I know it's there because with video's shot in widescreen (Like this one), the text appears in the top left as expected because of the gap left at the top. For all other videos though the overlay remains hidden in the background.

I found this issue in the overlay closed issues that says I need to include the overlay css, but doing so does not fix the problem.

I also found this issue that says I need to append the overlay to the videoPlayers containing div, which I think is the relative class, but have no success with that.

Any help would be greatly appreciated.

@GilgusMaximus
Copy link
Contributor

GilgusMaximus commented Nov 9, 2020

Hi, so it would be great if you can create a PR and mark it as draft and label it with 'Help wanted'. Then everyone sees that a new PR is available and can take a look. Because we are also not so invested into VideoJS plugins, it might take a bit until help arrives.

But great work so far that it is working on some videos already. Getting something to work partially is always the first step towards fixing up the last bits 👍

@TDDR
Copy link
Contributor

TDDR commented Nov 15, 2020

Hey @GilgusMaximus , I made a little more progress since last time but there's still one nagging issue. I made a draft PR like you suggested but I cannot change the labels to it. Could you please add the help wanted label to that PR.

@PrestonN
Copy link
Member

I added the tag for you. I'll review / help out sometime tomorrow to help finish up the PR.

@GilgusMaximus
Copy link
Contributor

Please open up a new issue for this bug to make it visible to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants