Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to copy channel link on channel pages #1414

Closed
peepo5 opened this issue Jun 14, 2021 · 3 comments · Fixed by #2859
Closed

Add button to copy channel link on channel pages #1414

peepo5 opened this issue Jun 14, 2021 · 3 comments · Fixed by #2859
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@peepo5
Copy link
Contributor

peepo5 commented Jun 14, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
When I visit a channel page, I sometimes need to copy the channel link. The only method (i know of) to copy the channel link in either invidious format or youtube format is by clicking the three dots on a random video and copying there. It would make mich more sense to add a new button to the page with either a share icon or the words "share" which could share to invidious or youtube. Picture is below.

Describe the solution you'd like to see implemented
Button added to channel pages.

Screenshots
image
Adding something like this would be cool. I think a share icon might look nicer here. Also it would be better not colored so the unsubscribe stands out
@peepo5 peepo5 added the enhancement New feature or request label Jun 14, 2021
@GilgusMaximus GilgusMaximus mentioned this issue Jun 17, 2021
Closed
@Victor239 Victor239 mentioned this issue Jun 17, 2021
Closed
@peepo5
Copy link
Contributor Author

peepo5 commented Jun 27, 2021

also, i feel the underlining of the videos, playlists, and about look kind of clunky, look more like links than buttons

@ChunkyProgrammer ChunkyProgrammer mentioned this issue Jun 29, 2021
Merged
2 tasks
@ChunkyProgrammer ChunkyProgrammer added the good first issue Good for newcomers label Aug 16, 2022
Closed
2 tasks
@Alhuin
Copy link
Contributor

Alhuin commented Nov 12, 2022

I'll work on it !

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Thanks @Alhuin, we're looking forward seeing your PR!

Alhuin added a commit to Alhuin/FreeTube that referenced this issue Nov 12, 2022
@Alhuin
FreeTubeApp#1414: Add share button ton Channel view
ea362ab 
- Update src/renderer/components/ft-share-button to handle Channels
- Update english locale entries for 'Share channel'
Alhuin added a commit to Alhuin/FreeTube that referenced this issue Nov 12, 2022
@Alhuin
FreeTubeApp#1414: Add share button ton Channel view
0ae08f2 
- update youtubeShareURL() in src/renderer/components/ft-share-button
Alhuin added a commit to Alhuin/FreeTube that referenced this issue Nov 12, 2022
@Alhuin
FreeTubeApp#1414: Add share button ton Channel view
646b1c0 
- implemented the new button in src/renderer/views/Channel
@Alhuin Alhuin mentioned this issue Nov 12, 2022
Merged
4 tasks
Alhuin added a commit to Alhuin/FreeTube that referenced this issue Nov 13, 2022
@Alhuin
FreeTubeApp#1414: Add share button ton Channel view
2156174 
- renamed mediaType to shareTargetType in ft-share-button.js
- switched logic from !isChannel to isVideo in ft-share-button.vue
Alhuin added a commit to Alhuin/FreeTube that referenced this issue Nov 13, 2022
@Alhuin
FreeTubeApp#1414: Add share button ton Channel view
ad9dcdd 
- renamed target type in ft-share-button.vue
- updated implementation in Channel.vue
FreeTubeBot pushed a commit that referenced this issue Nov 14, 2022
@Alhuin
#1414 share channels (#2859)
3d473d9 
* #1414: Add share button ton Channel view
- Update src/renderer/components/ft-share-button to handle Channels
- Update english locale entries for 'Share channel'

* #1414: Add share button ton Channel view
- update youtubeShareURL() in src/renderer/components/ft-share-button

* #1414: Add share button ton Channel view
- implemented the new button in src/renderer/views/Channel

* #1414: Add share button ton Channel view
- renamed mediaType to shareTargetType in ft-share-button.js
- switched logic from !isChannel to isVideo in ft-share-button.vue

* #1414: Add share button ton Channel view
- renamed target type in ft-share-button.vue
- updated implementation in Channel.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1414 share channels Alhuin/FreeTube
4 participants
@Alhuin @peepo5 @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer