#1414 share channels #2859
Merged
#1414 share channels #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update src/renderer/components/ft-share-button to handle Channels - Update english locale entries for 'Share channel'
- update youtubeShareURL() in src/renderer/components/ft-share-button
- implemented the new button in src/renderer/views/Channel
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
requested review from
ChunkyProgrammer,
absidue,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
requested changes
Nov 13, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
- renamed mediaType to shareTargetType in ft-share-button.js - switched logic from !isChannel to isVideo in ft-share-button.vue
- renamed target type in ft-share-button.vue - updated implementation in Channel.vue
auto-merge was automatically disabled
November 13, 2022 01:29
Head branch was pushed to by a user without write access
Alhuin
requested review from
PikachuEXE
and removed request for
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer and
absidue
ChunkyProgrammer
approved these changes
Nov 14, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 14, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1414 Add button to share channel link on channel views
Pull Request Type
Related issue
closes #1414
Description
Add a new share icon in the Channel view.
At first, I implemented this as a dropdown button but this wasn't pretty in terms of UI.
In a second step, I wrote a component ft-share-channel-button, but it was clearly a duplicate of the ft-share-button with less content.
I finally edited the ft-share-button so that it takes a new optionnal parameter:
mediaTypeshareTargetType:mediaTypeshareTargetType is 'Video')One consequence: The property getTimestamp is not required anymore.
I would have liked to do something like
required=this.mediaType === 'Video'but could not make this work, so I implemented a mount() function to check the case where the component would be instanciated for a video without it, it will only console.error.Screenshots
Before
After
Testing
Click on the share icon on any Channel view.
Desktop
Additional context
This is my first contribution to an open source project and first time using VueJs and Electron, any feedback on the worflow or the code style will be greatly appreciated !