Feature: Screenshot of video

[hockerschwan]

Pull Request Type

• Feature Implementation

Related issue
Closes #1027

Description
Save as PNG / JPG, full resolution of the video (e.g., 1920x1080)
Keyboard shortcut (currently using "U")
Operating system's "Pictures" folder as default save location
File name customization / subfolder

Screenshots

Testing
Tested Local / Invidious and Dash / Legacy

Desktop

• OS: Windows 10 21H1, Ubuntu 20.04

Additional context
File name pattern tooltip is not looking great ( can't use newline )

[efb4f5ff-1298-471a-8973-3d47447115dc]

First of all this is very very cool!

• Press U > Click on Take screenshot it works both in this sequence
• Click on Take Screenshot > Press U takes screenshot when u click but doesnt when u press U
• Could u rename Take Screenshot to Screenshot
• I would like to see a toggle in the settings. Something like Enable Screenshot. After u enabled it all the settings related to screenshot will be visible and the icon in the player also will be visible after enabling the toggle.
• Would like to see a toggle 'Ask for download path' just like in the download settings. This will prompt the user to manually chose the download path every time they take a screenshot.
• Screenshots folder path should be editable for someone to type a path in but shouldnt be editable when Ask for download path is enabled

[efb4f5ff-1298-471a-8973-3d47447115dc]

@hockerschwan ready for review again?

[hockerschwan]

Yes please.
Added "Save As" dialog ( modified showSaveDialog in utils.js and src/main/index.js to show modal window. existing dialogs such as "Export History" etc. remain modeless )

Click on Take Screenshot > Press U takes screenshot when u click but doesnt when u press U

This happens with other buttons. Click pause or mute button and you can't use shortcut.

[efb4f5ff-1298-471a-8973-3d47447115dc]

LGTM!

* Screenshots folder path should be editable for someone to type a path in but shouldnt be editable when Ask for download path is enabled

This was still missing but i think that something like this is a nice to have but not really necessary. I'd like to hear from the other if they agree or disagree on this

[PikachuEXE]

Let's start with simple variable naming issue
Will test feature locally later

Will review rest of the code when I really have time (busy~~)

[PikachuEXE]

• Settings visibility tested
• Save in subfolder tested (with %Y%M%D/%Y%M%D--%H%N%S)
• Ask for folder tested
• Keyboard shortcut (U) tested
• On player button tested
• image format tested
• image quality tested (LOL at 0%)

What else should be tested?

0% jpg looks great in file size (only) 😆

Update: also tested file pattern variables with %Y%M%D/%Y%M%D-%H%N%S-%T--%i--%s-%t

[hockerschwan]

Isn't that beautiful?

Does "Pictures folder" (like "C:\Users\[user]\Pictures") work on mac when screenshotFolderPath is empty ?

[PikachuEXE]

How do I make it empty?

[efb4f5ff-1298-471a-8973-3d47447115dc]

@PikachuEXE did u try to use Thunderbolt?

[hockerschwan]

That's the default and working as intended, thanks

[PikachuEXE]

Unless I miss something untested this can be merged

[PikachuEXE]

@absidue @ChunkyProgrammer ?