Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: screenshot forbidden chars on Windows #2318

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix: screenshot forbidden chars on Windows #2318

merged 1 commit into from
Jun 15, 2022

Conversation

hockerschwan
Copy link
Contributor

Pull Request Type
Please select what type of pull request this is:

  • Bugfix

Related issue
None

Description
I forgot to add '?' and '*' to #2221 for win32

Desktop (please complete the following information):

  • OS: Windows 10 21H1
  • FreeTube version: 0.16

@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 23:15
auto-merge was automatically disabled June 13, 2022 23:16

Base branch changed by a user without write access

@hockerschwan hockerschwan changed the base branch from development to v0.17.0-RC June 13, 2022 23:16
@PrestonN PrestonN enabled auto-merge (squash) June 13, 2022 23:16
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 14, 2022
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've changed the base branch to the RC branch, please create a duplicate PR to the development branch, that way they can be tracked separately (same for #2313 and #2310).

@hockerschwan
Copy link
Contributor Author

Done!

@PrestonN PrestonN merged commit c12d64c into FreeTubeApp:v0.17.0-RC Jun 15, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 15, 2022
@hockerschwan hockerschwan deleted the fix-screenshot-chars branch June 15, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants