Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Picture in Picture button and disable keyboard shortcut for audio formats #2227

Merged
merged 1 commit into from
May 2, 2022

Conversation

absidue
Copy link
Member

@absidue absidue commented Apr 30, 2022


Hide Picture in Picture button and disable keyboard shortcut for audio formats

Pull Request Type

  • Feature Implementation

Description
Please write a clear and concise description of what the pull request does.

Screenshots

Before

before_audio

errors

After

after_video

after_audio

Testing
I tested various videos and checked that it works regardless of which formats are set as default and that it works when the formats are changed on the video page. The video used for the screenshots is this one: https://youtu.be/lIxAPW0YAEU

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: e29d041

@PrestonN PrestonN enabled auto-merge (squash) April 30, 2022 11:26
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 30, 2022
@PrestonN PrestonN merged commit 1e5895a into FreeTubeApp:development May 2, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 2, 2022
@absidue absidue deleted the hide-pip-audio branch May 2, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants