Better solution for hiding the PIP button for the audio formats #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
|
The more timeouts and intervals we remove from our code, the better 🙂 |
ChunkyProgrammer
previously approved these changes
Feb 8, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Feb 8, 2023
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and ChunkyProgrammer
via
ccec96d
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Feb 9, 2023
PikachuEXE
approved these changes
Feb 10, 2023
ChunkyProgrammer
approved these changes
Feb 10, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better solution for hiding the PIP button for the audio formats
Pull Request Type
Related issue
originally implemented in #2227
Description
Since the original pull request I've learnt a lot more about FreeTube's code and have found out that the ft-player component is destroyed and recreated when the formats are changed, so I've now changed the implementation so video.js doesn't even add the PIP button to the player if the audio formats are selected.
This gets rid of a setInterval call which was based on an arbitrary timeout, yay :)
Testing
Watch a video and change the formats.
Desktop