Add feature to remember video history with last viewed playlist when enabled #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: WIP
and removed
PR: waiting for review
PikachuEXE
force-pushed
the
feature/history-remember-list
branch
from
ebaf79a to
ec06ff6
Compare
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
PikachuEXE
force-pushed
the
feature/history-remember-list
branch
from
ec06ff6 to
6a2de24
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
auto-merge was automatically disabled
January 3, 2023 05:28
Pull request was converted to draft
PikachuEXE
added
PR: WIP
and removed
PR: waiting for review
PikachuEXE
force-pushed
the
feature/history-remember-list
branch
from
6a2de24 to
e887729
Compare
PikachuEXE
added
PR: waiting for review
|
Fixed & tested case for
|
|
I see that u changed the label from wip to waiting for review but the PR is still a draft. Did u forget to undraft it? |
PikachuEXE
force-pushed
the
feature/history-remember-list
branch
from
def41a9 to
974b1ad
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ChunkyProgrammer
added
the
PR: waiting for review
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Gonna rebase this after #3066
|
…to view, go to channel, view that same video, no playlist restored"
PikachuEXE
force-pushed
the
feature/history-remember-list
branch
from
974b1ad to
63269ad
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
absidue
approved these changes
Jan 22, 2023
|
@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc |
ChunkyProgrammer
approved these changes
Jan 25, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 26, 2023
github-actions
bot
removed
the
PR: waiting for review
4 tasks
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to remember video history with last viewed playlist when enabled
Pull Request Type
Related issue
N/A
Description
This is a feature I want XD
I constantly listen to specific playlists and it's quite annoying to sometimes having to close the app
And after app restart I go back to history but unable to continue my playback progress with the last viewed playlist
So I write this feature for myself :D
There is a new option too which can be disabled (but enabled by default)
The playlist would only be applied when visited via history
If video viewed via URL pasted (with/without playlist) or non-history list it should not restore last viewed playlist
Screenshots
Settings
Testing
Disabled
Should be old behaviour
Enabled
If you need actual videos & playlists provided as test cases let me know
Desktop
Additional context