Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix last view playlist saving with multiple windows #3137

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Fix last view playlist saving with multiple windows #3137

merged 2 commits into from
Feb 6, 2023

Conversation

PikachuEXE
Copy link
Collaborator

Fix last view playlist saving with multiple windows

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Fixes issue in feature introduced by #3006

Description

I found that sometimes my written feature #3006 is not working
This should fix it

Screenshots

image

Testing

  • Ensure history does not contain the video to be tested
  • Open a new window (2+ in total, referred as A & B)
  • In A, watch the video with playlist and stay in watch view
  • In B, visit history view and click on new entry
  • Ensure in B you still see playlist when video being played

Desktop

  • OS: MacOS
  • OS Version: 12.6.2
  • FreeTube version: b02b3e9

Additional context

This bug is caused by calling the saving before history entry for the video is added, but it still works sometimes since there is another call when route changed
Thus first time watched videos without leaving the watch view will be saved without the last viewed playlist

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 30, 2023 08:57
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2023
@PikachuEXE
Copy link
Collaborator Author

@ChunkyProgrammer @efb4f5ff-1298-471a-8973-3d47447115dc
Please review when free~
sM7Lgcs

@PikachuEXE
Copy link
Collaborator Author

@ChunkyProgrammer
Please help us
image

@FreeTubeBot FreeTubeBot merged commit 20064c6 into FreeTubeApp:development Feb 6, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 6, 2023
@PikachuEXE PikachuEXE deleted the feature/history-remember-list branch February 6, 2023 01:51
@PikachuEXE
Copy link
Collaborator Author

Thank you all
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot