Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loading forever in live chat in non-electron builds #3449

Conversation

MarmadileManteater
Copy link
Contributor

Prevent loading forever in live chat in non-electron builds

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

MarmadileManteater#151

Description

In the created hook of the watch-video-live-chat component, the isLoading flag is never set to false when process.env.IS_ELECTRON is false. The result is that the component appears to be loading forever, and never displays the appropriate message: "Live Chat is currently not supported in this build" in non-electron builds.

Screenshots

before after
image image

Testing

  1. yarn dev:web
  2. Navigate to a live video with a chat. EX: https://youtu.be/jfKfPfyJRdk
  3. Ensure that the live chat displays the message "Live Chat is currently not supported in this build."

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 92d969b

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 19, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) April 19, 2023 01:19
@FreeTubeBot FreeTubeBot merged commit 791a289 into FreeTubeApp:development Apr 19, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 19, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Apr 21, 2023
* development:
  Fix extracting chapters with handles from description (FreeTubeApp#3456)
  * Update video list display & watch page to not use stored watch progress when progress saving disabled (FreeTubeApp#3453)
  Update invidious-instances.json (FreeTubeApp#3440)
  Prevent loading for ever in web builds in live chat (FreeTubeApp#3449)
  Bump postcss from 8.4.21 to 8.4.22 (FreeTubeApp#3435)
  Bump html-webpack-plugin from 5.5.0 to 5.5.1 (FreeTubeApp#3432)
  Bump webpack from 5.78.0 to 5.79.0 (FreeTubeApp#3436)
  Bump sass from 1.61.0 to 1.62.0 (FreeTubeApp#3433)
  Fix "mention" in comments was rendered as link with channel URL (FreeTubeApp#3351)
  Fix live premieres being treated as non-live videos (FreeTubeApp#3358)
  Bump eslint-plugin-vue from 9.10.0 to 9.11.0 (FreeTubeApp#3434)
  Bump webpack-dev-server from 4.13.2 to 4.13.3 (FreeTubeApp#3437)
  Bump youtubei.js from 4.2.0 to 4.3.0 (FreeTubeApp#3438)
  Bump lefthook from 1.3.9 to 1.3.10 (FreeTubeApp#3439)
@MarmadileManteater MarmadileManteater deleted the prevent-loading-live-chat-forever-in-web branch March 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants