Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Live chat doesn't load #151

Closed
5 tasks done
ChunkyProgrammer opened this issue Apr 18, 2023 · 2 comments
Closed
5 tasks done

[Bug]: Live chat doesn't load #151

ChunkyProgrammer opened this issue Apr 18, 2023 · 2 comments
Assignees
Labels
B: API issue bug Something isn't working

Comments

@ChunkyProgrammer
Copy link

ChunkyProgrammer commented Apr 18, 2023

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. go to a live video (ex: https://www.youtube.com/watch?v=jfKfPfyJRdk)
  2. scroll to live chat
  3. live chat loads forever

live chat infinite loading

Expected Behavior

Live chat should load or be hidden

Issue Labels

API issue

FreeTube Version

v0.18.0.107

Operating System Version

Android 12

Installation Method

.apk

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@ChunkyProgrammer ChunkyProgrammer added the bug Something isn't working label Apr 18, 2023
MarmadileManteater added a commit that referenced this issue Apr 19, 2023
This is related to #151.
@MarmadileManteater
Copy link
Owner

MarmadileManteater commented Apr 19, 2023

I realized that I forgot to change the check for !IS_ELECTRON to include cordova, but the reason the chat never loads is because the isLoading flag is never set to false when the process.env.IS_ELECTRON flag is false. It is supposed to show the text: "Live Chat is currently not supported in this build.", but since the isLoading flag never gets set to false, you can't see it. That might be a change worth making upstream because, while it doesn't involve the electron build, it would still probably effect the web version of freetube that can be tested with the yarn dev:web command upstream.

@MarmadileManteater
Copy link
Owner

I finally got around to pulling in upstream changes, and now, the PR that 🔨fixes this issue is merged into the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: API issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants