Fix live videos as list items had no save to playlist button #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already present in watch page
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
Closed
4 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 29, 2023
| @@ -45,7 +45,7 @@ | |||
| @click="handleExternalPlayer" | |||
| /> | |||
| <ft-icon-button | |||
| v-if="!isLive" | |||
| v-if="!isUpcoming" | |||
There was a problem hiding this comment.
Just curious, do we want to stop upcoming videos from being saved? I think for a "watch later" playlist it could make sense to be able to add upcoming videos (if it doesn't cause any other issues, of course). Going to approve as this PR is fixing an inconsistancy, this is just a thought I had
There was a problem hiding this comment.
Feel free to open PR (I am just fixing consistency issue here)
ChunkyProgrammer
approved these changes
May 29, 2023
absidue
approved these changes
May 29, 2023
github-actions
bot
removed
the
PR: waiting for review
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
N/A
Description
Fix live videos as list items had no save to playlist button
Such button is already present in watch page (for live videos)
Screenshots
After:
Testing
Desktop
Additional context
More references:
Video as List Item Behaviour
Watch Page Behaviour