Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live videos as list items had no save to playlist button #3598

Merged
merged 1 commit into from
May 29, 2023
Merged

Fix live videos as list items had no save to playlist button #3598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderer/components/ft-list-video/ft-list-video.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
@click="handleExternalPlayer"
/>
<ft-icon-button
v-if="!isLive"
v-if="!isUpcoming"
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer May 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, do we want to stop upcoming videos from being saved? I think for a "watch later" playlist it could make sense to be able to add upcoming videos (if it doesn't cause any other issues, of course). Going to approve as this PR is fixing an inconsistancy, this is just a thought I had

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to open PR (I am just fixing consistency issue here)

:title="$t('Video.Save Video')"
:icon="['fas', 'star']"
class="favoritesIcon"
Expand Down