-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix localization of counts #4011
Changes from all commits
72ca3ac
78d1341
d3327bf
b696f9d
faf3291
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -575,8 +575,6 @@ Profile: | |
Profile Filter: Profile Filter | ||
'{number} selected': '{number} selected' | ||
Channel: | ||
Subscriber: 'Subscriber' | ||
Subscribers: 'Subscribers' | ||
Subscribe: 'Subscribe' | ||
Unsubscribe: 'Unsubscribe' | ||
Channel has been removed from your subscriptions: 'Channel has been removed from | ||
|
@@ -649,15 +647,12 @@ Video: | |
Copy YouTube Embedded Player Link: 'Copy YouTube Embedded Player Link' | ||
Open in Invidious: 'Open in Invidious' | ||
Copy Invidious Link: 'Copy Invidious Link' | ||
View: 'View' | ||
Views: 'Views' | ||
Loop Playlist: 'Loop Playlist' | ||
Shuffle Playlist: 'Shuffle Playlist' | ||
Reverse Playlist: 'Reverse Playlist' | ||
Play Next Video: 'Play Next Video' | ||
Play Previous Video: 'Play Previous Video' | ||
# Context is "X People Watching" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do see that we're not including this comment anymore, which I think is fine as the pluralization and placement makes the context of the translation label more intuitive. As a sidenote, comments like these do make me wonder if having implicit subjects/objects in our labels is a burden for [a subset of] our translators; I have no idea. |
||
Watching: 'Watching' | ||
Watched: 'Watched' | ||
Autoplay: 'Autoplay' | ||
Starting soon, please refresh the page to check again: 'Starting soon, please refresh | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though not mentioned by
https://kazupon.github.io/vue-i18n/guide/pluralization.html#pluralization
When zero value not provided and count is zero, the plural version is used (I tested locally) (for en at least)