Add logo hover styling #4209
Merged
Add logo hover styling #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
This PR broken hover for other buttons (only logo is ok) Expected: |
kommunarr
force-pushed
the
feat/add-logo-hover-styling
branch
from
4bf7d36 to
815e1b9
Compare
|
So sorry about that one; intended to draft this for today. I was being careless with the CSS ordering; check again now. |
PikachuEXE
approved these changes
Oct 22, 2023
absidue
approved these changes
Oct 22, 2023
ChunkyProgrammer
approved these changes
Oct 23, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 26, 2023
* development: (26 commits) Translated using Weblate (Portuguese) Ensure updated locales are auto-reloaded in electron renderer dev mode (FreeTubeApp#4066) Translated using Weblate (Portuguese) Translated using Weblate (Russian) Translated using Weblate (Latvian) Added translation using Weblate (Latvian) Translated using Weblate (Portuguese) Bump sass from 1.69.3 to 1.69.4 (FreeTubeApp#4216) Bump the stylelint group with 1 update (FreeTubeApp#4214) Bump the eslint group with 2 updates (FreeTubeApp#4213) Bump vue from 2.7.14 to 2.7.15 (FreeTubeApp#4217) Bump electron from 27.0.0 to 27.0.2 (FreeTubeApp#4215) Translated using Weblate (Portuguese) Add logo hover styling (FreeTubeApp#4209) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese) Translated using Weblate (Portuguese) Update CONTRIBUTING.md (FreeTubeApp#4208) Translated using Weblate (Portuguese) Translated using Weblate (Samoan) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logo hover styling [minor change]
Pull Request Type
Related issue
See comment
Description
Adds hover styling to logo to make it clearer that it is interactive.
Screenshots
Testing
Try hovering in different themes with "Match Top Bar with Main Color" on and off
Desktop