Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make landing page configurable #4200

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Make landing page configurable #4200

merged 5 commits into from
Nov 20, 2023

Conversation

kommunarr
Copy link
Collaborator

Make landing page configurable

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #183

Description

Implements setting to customize your landing page on startup. Only includes routes without params. Also slightly reorders routes to closer match the more logical order of how they appear in the application and adds name properties to a handful (not used here, but nice to have handy).

Screenshots

Screenshot_20231021_011521

Testing

  • Go to General Settings and change the default landing page. Confirm that it is populated correctly with a default value.
  • Change to one of the values. Restart application -- not just refresh (i.e., NOT CTRL+R) -- and ensure page is used as starting page. Repeat for all values.

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 21, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 21, 2023 06:16
@absidue
Copy link
Member

absidue commented Oct 21, 2023

I think it's probably better to have a hard coded list, that way it won't include stuff that people are unlikely to ever select like About, Create New Profile and the Profile Settings page.

@kommunarr
Copy link
Collaborator Author

I think it's probably better to have a hard coded list, that way it won't include stuff that people are unlikely to ever select like About, Create New Profile and the Profile Settings page.

I can get that reasoning. My reasoning was "eh, if someone wants it, who am I to stand in the way." That and the elegance of reusing the meta.titles. Certainly have no problem changing this part if others agree.

@PikachuEXE
Copy link
Collaborator

Agree on whitelist

@kommunarr kommunarr force-pushed the feat/custom-landing-page branch from 4d89e4f to 8c26cfb Compare October 21, 2023 14:59
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

If u click the FT logo in the top bar it takes u to the subscriptions page (current main landing page). IMO that should be based on the user configuration.

Just a unrelated note: Maybe accessibility issue? when i hover over the FT logo it doesn't show a hover effect like with the other icons in the top bar

@kommunarr kommunarr mentioned this pull request Oct 21, 2023
Merged
4 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Most Popular should only be in there if IV API is set as primary or fallback is enabled
  • If distraction free setting Hide Trending/Popular/Playlist is enabled -> hide them from dropdown

@kommunarr
Copy link
Collaborator Author

  • Most Popular should only be in there if IV API is set as primary or fallback is enabled

    • If distraction free setting Hide Trending/Popular/Playlist is enabled -> hide them from dropdown

Ah, you're right, although it will be a bit more than that, as those can be changed in any order. Looking at it now.

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit 58fe474 into FreeTubeApp:development Nov 20, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 20, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 21, 2023
@PikachuEXE
Merge branch 'development' into feature/playlist-2023-05
fdb8c75 
* development:
  Update to silently allow channel links (with IDs) (FreeTubeApp#4347)
  Add hide channel option directly to More Options menu (FreeTubeApp#4228)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Spanish)
  Make landing page configurable (FreeTubeApp#4200)
  Bump @silvermine/videojs-quality-selector from 1.3.0 to 1.3.1 (FreeTubeApp#4362)
  Bump electron from 27.0.4 to 27.1.0 (FreeTubeApp#4363)
  Bump the eslint group with 1 update (FreeTubeApp#4360)
  Bump actions/github-script from 6 to 7 (FreeTubeApp#4361)
  add image to poll & updated quiz style (FreeTubeApp#4318)
  Move hideOutlines to the utils store instead of using provide/inject (FreeTubeApp#4246)
  Translated using Weblate (Kurdish (Central))
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (French)
  Translated using Weblate (German)
  Added translation using Weblate (Kurdish (Central))
  Translated using Weblate (Slovak)

# Conflicts:
#	src/renderer/components/ft-list-video/ft-list-video.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue Awaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to choose which page view to start on
6 participants
@kommunarr @absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot