Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images to community polls #4318

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

Benjababe
Copy link
Contributor

@Benjababe Benjababe commented Nov 11, 2023

Add images to community polls

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #4309

Description

Adds images to polls and updated the style of quiz answers.

Screenshots

image

asdf.mp4

Testing

Tried on:

on invidious and local api

Desktop

  • OS: Windows 10
  • OS Version: 22H2
  • FreeTube version:

Additional context

Should the empty circles on the left be removed to fit youtube's UI?

image

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 11, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 11, 2023 09:00
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why empty circles were added
So no idea if they should be removed

@kommunarr
Copy link
Collaborator

Probably should be removed, given that the user has no ability to make a choice. Or altered with disabled and/or penciled-in styling. But not in scope for this PR, so that should be good for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the empty circles on the left be removed to fit youtube's UI?

Yes but that is a non blocking issue. So i leave it up to you if you want to implement it here or in a separate pr

Everything LGTM though

Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another pre-existing issue is that we show an incorrect number of significant figures in the counts for these polls.

Screenshot_20231116_210205

LGTM

@FreeTubeBot FreeTubeBot merged commit c57daa8 into FreeTubeApp:development Nov 17, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 17, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 21, 2023
* development:
  Update to silently allow channel links (with IDs) (FreeTubeApp#4347)
  Add hide channel option directly to More Options menu (FreeTubeApp#4228)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Spanish)
  Make landing page configurable (FreeTubeApp#4200)
  Bump @silvermine/videojs-quality-selector from 1.3.0 to 1.3.1 (FreeTubeApp#4362)
  Bump electron from 27.0.4 to 27.1.0 (FreeTubeApp#4363)
  Bump the eslint group with 1 update (FreeTubeApp#4360)
  Bump actions/github-script from 6 to 7 (FreeTubeApp#4361)
  add image to poll & updated quiz style (FreeTubeApp#4318)
  Move hideOutlines to the utils store instead of using provide/inject (FreeTubeApp#4246)
  Translated using Weblate (Kurdish (Central))
  Translated using Weblate (English (United Kingdom))
  Translated using Weblate (French)
  Translated using Weblate (German)
  Added translation using Weblate (Kurdish (Central))
  Translated using Weblate (Slovak)

# Conflicts:
#	src/renderer/components/ft-list-video/ft-list-video.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support GIFs in Community Polls
6 participants