Cleanup SponsorBlock video id hashing #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 25, 2023
ChunkyProgrammer
approved these changes
Nov 25, 2023
PikachuEXE
approved these changes
Nov 26, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 29, 2023
* development: (38 commits) Channel subscribe button in search results (FreeTubeApp#4376) Translated using Weblate (Czech) Translated using Weblate (Portuguese (Brazil)) Use F5 to refresh subscriptions (FreeTubeApp#4399) Miscellaneous improvements to settings page styling (FreeTubeApp#4235) Translated using Weblate (Icelandic) Translated using Weblate (Swedish) Translated using Weblate (Arabic) Bump lefthook from 1.5.2 to 1.5.4 (FreeTubeApp#4398) Bump electron from 27.1.0 to 27.1.2 (FreeTubeApp#4395) Bump electron-builder from 24.6.4 to 24.9.1 (FreeTubeApp#4397) Translated using Weblate (Portuguese) Translated using Weblate (French) Fix bug (FreeTubeApp#4392) Translated using Weblate (Spanish) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Serbian) Translated using Weblate (Chinese (Simplified)) Translated using Weblate (Italian) Cleanup SponsorBlock video id hashing (FreeTubeApp#4384) ... # Conflicts: # src/renderer/scss-partials/_ft-list-item.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup SponsorBlock video id hashing
Pull Request Type
Description
Currently the code to create the video ID hash prefix to send to SponsorBlock is rather inefficient, this pull request aims to simplify it, making it more efficient.
Currently it creates an array from the unsigned 8-bit integer array, calls map on it to create a new array with the bytes coverted to hex strings, creates a new array with the first 4 and then joins them to a string, after that it creates a new string with the first 4 characters (this step could have been avoided if only the first two bytes had been chosen in an earlier step, instead of 4).
The new code selects the first two bytes in the unsigned 8-bit integer array and converts those to hex strings and then concatenates them together. This saves a bunch of temporary arrays and strings and also simplifies the code.
Testing
The testing for this pull request is just regression testing.
Turn on SponsorBlock and open a video with SponsorBlock segments, they should still show up in the seek bar and be skipped if you have that configued.
Turn on DeArrow and make sure titles are still being replaced.