Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings section close on interaction bug #4392

Merged

Conversation

kommunarr
Copy link
Collaborator

Fix settings section bug

Pull Request Type

  • Bugfix

Related issue

#4379 (comment)

Description

This was easier than I was anticipating.

Testing

  • Disable Expand All Settings Sections disabled -> interact with toggles in sections and observe sections are not auto-closing
  • And vice versa when setting is enabled
  • Ensure Enable/Disable opens/closes all sections appropriately

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 26, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 26, 2023 22:06
@FreeTubeBot FreeTubeBot merged commit c547c15 into FreeTubeApp:development Nov 27, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 27, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 29, 2023
* development: (38 commits)
  Channel subscribe button in search results (FreeTubeApp#4376)
  Translated using Weblate (Czech)
  Translated using Weblate (Portuguese (Brazil))
  Use F5 to refresh subscriptions (FreeTubeApp#4399)
  Miscellaneous improvements to settings page styling (FreeTubeApp#4235)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Swedish)
  Translated using Weblate (Arabic)
  Bump lefthook from 1.5.2 to 1.5.4 (FreeTubeApp#4398)
  Bump electron from 27.1.0 to 27.1.2 (FreeTubeApp#4395)
  Bump electron-builder from 24.6.4 to 24.9.1 (FreeTubeApp#4397)
  Translated using Weblate (Portuguese)
  Translated using Weblate (French)
  Fix bug (FreeTubeApp#4392)
  Translated using Weblate (Spanish)
  Translated using Weblate (Chinese (Traditional))
  Translated using Weblate (Serbian)
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Italian)
  Cleanup SponsorBlock video id hashing (FreeTubeApp#4384)
  ...

# Conflicts:
#	src/renderer/scss-partials/_ft-list-item.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants