Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly localize playlist view and video counts #4620

Conversation

ChunkyProgrammer
Copy link
Member

Properly localize playlist view and video counts

Pull Request Type

  • Bugfix - localization

Related issue

Missing from #4011

Description

Properly localize the playlist counts using the Global counts we have in the locale files.

Screenshots

image

Testing

  • go to a playlist
  • notice video count and view count is properly formatted

Desktop

  • OS: Linux Mint
  • OS Version: 21.3
  • FreeTube version: 0.19.1

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 29, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 29, 2024 23:06
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go to a playlist

remote playlist

@FreeTubeBot FreeTubeBot merged commit cec2d36 into FreeTubeApp:development Jan 31, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 31, 2024
@ChunkyProgrammer ChunkyProgrammer deleted the properly-localize-playlist-views-and-videos branch January 31, 2024 15:42
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Feb 1, 2024
…into custom-builds/current

* feature/playlist-search-videos-in-one-user-playlist-2:
  ! Fix load more button appears when searching & visible items under pagination limit
  * Update single playlist view for user playlists to add search video function
  Playlist performance improvements (FreeTubeApp#4597)
  ! Fix playlist type not passed when playing next/prev item in a user playlist (FreeTubeApp#4623)
  Properly localize playlist view and video counts (FreeTubeApp#4620)
  Translated using Weblate (Croatian)
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Feb 3, 2024
* development: (92 commits)
  Make video info section more concise (FreeTubeApp#4338)
  Playlist performance improvements (FreeTubeApp#4597)
  ! Fix playlist type not passed when playing next/prev item in a user playlist (FreeTubeApp#4623)
  Properly localize playlist view and video counts (FreeTubeApp#4620)
  Translated using Weblate (Croatian)
  Translated using Weblate (German)
  Translated using Weblate (Croatian)
  Fix search bar handling of Invidious channel URLs (FreeTubeApp#4568)
  Local API: List related games in featured channels section (FreeTubeApp#4562)
  Workaround community post slider dependency incorrectly calculating its size (FreeTubeApp#4598)
  Add support for viewing movie trailers with local api (FreeTubeApp#4391)
  Bump the eslint group with 2 updates (FreeTubeApp#4616)
  Translated using Weblate (French)
  Translated using Weblate (Finnish)
  Bump electron from 28.1.4 to 28.2.0 (FreeTubeApp#4611)
  Translated using Weblate (French)
  Bump the eslint group with 4 updates (FreeTubeApp#4581)
  Bump lefthook from 1.6.0 to 1.6.1 (FreeTubeApp#4608)
  Bump marked from 11.1.1 to 11.2.0 (FreeTubeApp#4612)
  Bump webpack from 5.89.0 to 5.90.0 (FreeTubeApp#4610)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants