Split view count and published date into two lines on small displays #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
reviewed
Mar 3, 2024
| @@ -70,31 +70,43 @@ | |||
| .videoMetrics { | |||
| font-size: 14px; | |||
| color: var(--tertiary-text-color); | |||
|
|
|||
There was a problem hiding this comment.
Why removing the blank line
There was a problem hiding this comment.
i mistakenly removed it, but it should be back now
Co-authored-by: PikachuEXE <git@pikachuexe.net>
PikachuEXE
approved these changes
Mar 3, 2024
absidue
approved these changes
Mar 3, 2024
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
kommunarr
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 4, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 6, 2024
* development: Translated using Weblate (Estonian) Bump mini-css-extract-plugin from 2.8.0 to 2.8.1 (FreeTubeApp#4742) Bump electron from 28.2.3 to 29.1.0 (FreeTubeApp#4743) Bump lefthook from 1.6.1 to 1.6.4 (FreeTubeApp#4740) Bump the babel group with 2 updates (FreeTubeApp#4739) Bump swiper from 11.0.6 to 11.0.7 (FreeTubeApp#4741) Bump electron-builder from 24.12.0 to 24.13.3 (FreeTubeApp#4744) Split view count and published date into two lines on small displays (FreeTubeApp#4736)
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 7, 2024
* development: (161 commits) Add video search in user playlist feature (FreeTubeApp#4622) Add discussion info when opening an issue (FreeTubeApp#4676) Translated using Weblate (Lithuanian) Translated using Weblate (Serbian) Translated using Weblate (Estonian) Bump mini-css-extract-plugin from 2.8.0 to 2.8.1 (FreeTubeApp#4742) Bump electron from 28.2.3 to 29.1.0 (FreeTubeApp#4743) Bump lefthook from 1.6.1 to 1.6.4 (FreeTubeApp#4740) Bump the babel group with 2 updates (FreeTubeApp#4739) Bump swiper from 11.0.6 to 11.0.7 (FreeTubeApp#4741) Bump electron-builder from 24.12.0 to 24.13.3 (FreeTubeApp#4744) Split view count and published date into two lines on small displays (FreeTubeApp#4736) Translated using Weblate (Chinese (Traditional)) Fix URL copied via right click menu (FreeTubeApp#4690) Translated using Weblate (Croatian) Wrap ft-icon buttons below before they go fully vertical (FreeTubeApp#4735) * Make activating a chapter selector makes window scroll to top like clicking on timestamp links (FreeTubeApp#4722) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Make video thumbnails have certain height before image loading starts to avoid layout shifts (FreeTubeApp#4723) ... # Conflicts: # src/renderer/views/Playlist/Playlist.vue
MarmadileManteater
deleted the
split-views-and-published-on-narrow-displays
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split view count and published date into two lines on small displays
Pull Request Type
Description
The view count tends to split in a way that looks awkward on small displays. The number part of the view count ends up on a different line than the text part of the view count, and it makes it a little difficult to read. This PR addresses this by splitting the published date and view count onto different lines on small displays so that the view count is less likely to wrap in this way.
Screenshots
Testing
<= 460pxDesktop
Additional context
I picked 460px because view counts and like counts can vary. The example video in the screenshots has plenty of space at screen width 460px, but not all videos do. That is why the width was picked.